Asset switcher efficiency enhancement #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion about selection on switch dialog init
…s happened during `refresh` method
…presentation combobox
… are switched at once
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| bool(missing_assets) | ||
| or bool(missing_versions) | ||
| or bool(missing_subsets) | ||
| or bool(missing_repres) |
| self.missing_docs = ( | ||
| bool(missing_assets) | ||
| or bool(missing_versions) | ||
| or bool(missing_subsets) |
|
|
||
| self.missing_docs = ( | ||
| bool(missing_assets) | ||
| or bool(missing_versions) |
BigRoy
reviewed
Jun 2, 2020
|
I believe @jasperges recently tested this feature and it "worked fine" for his needs. I believe @iLLiCiTiT at pype has also updated a variant of this code change. Should we get this merged? |
@tokejepsen found a bug. ynput/OpenPype#423 |
jasperges
added a commit
to jasperges/avalon-core
that referenced
this pull request
Jan 14, 2023
Now using the asset switcher improvements from getavalon#551.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current asset switcher dialog is querying all documents in very inefficient way. The same document may be queried many times in separate database calls which makes asset switcher GUI really slow.
Suggested solution
Query documents of one type only once per each refresh step. So all representations are queried in one call, their versions, subsets and assets are queried in separate calls which means, to get parenthood of all representations needs a maximum of 4 calls to DB. We also validate each step of refresh, to prevent querying data which will not be used. This is not perfect change, it can be done even faster (and more complicated), but the performance improvement over current implementation is significant.
We tested on a feature film with around 400 assets. The speed difference to open the switcher GUI is: 10s with current code, 1-2s with the new code.