Speed up getting assets for asset switcher #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every asset a database call was made. If you have lots of assets this can really add up and take quite some time (for me roughly 30 seconds for about 2000 assets). This change does only 2 database calls and then does the filtering afterwards. This reduces the time taken to around 3 seconds for about 2000 assets.
|
@iLLiCiTiT has worked on the same thing. |
|
Whoops, forgot to check other PR's first... will have a look at #551. |
|
Okay, sorry for the noise and nevermind. #551 works fine for me. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
When querying the assets to populate the asset switcher a database call was made for every asset. If you have lots of assets this can really add up and take quite some time (for me roughly 30 seconds for 2000 assets).
This change does only 2 database calls and then does the filtering afterwards. In my case this reduces the time taken to around 3 seconds for 2000 assets.