Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scenario retries info params #209

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

PiotrNestor
Copy link
Contributor

@sriv

Support for scenario retries data in ExecutionInfo.
This provides scenario execution retries information in the hooks context.

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@sriv sriv added the ReleaseCandidate Pr that is eligible for a release label Mar 5, 2024
@gaugebot
Copy link

gaugebot bot commented Mar 5, 2024

@PiotrNestor Thank you for contributing to gauge-dotnet. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@sriv sriv enabled auto-merge (squash) March 5, 2024 14:01
@PiotrNestor
Copy link
Contributor Author

@sriv
What's the problem with the FTs. There was no hook update this time ...

@sriv
Copy link
Member

sriv commented Mar 6, 2024

@PiotrNestor
Copy link
Contributor Author

PiotrNestor commented Mar 6, 2024

@sriv
The problem is then related to currentScenario.Retries in:

activatorWrapper.CreateInstance(executionContextScenarioType, currentScenario.Name, currentScenario.IsFailed,
                    currentScenario.Tags.ToArray(), currentScenario.Retries.MaxRetries, currentScenario.Retries.CurrentRetry)

But this should work OK with the latest gauge, gauge-csharp-lib and gauge-dotnet.

The problem is:

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
auto-merge was automatically disabled March 7, 2024 08:46

Head branch was pushed to by a user without write access

@sriv
Copy link
Member

sriv commented Mar 7, 2024

I need to look into this a bit deeper to understand the dependency bottleneck. I am stuck with some travel and work, so might take a few days to settle in and investigate. Apologies for this.

@PiotrNestor
Copy link
Contributor Author

PiotrNestor commented Mar 7, 2024

@sriv
I've added logic to handle 'currentScenario.Retries' being null when running FT tests with a previous gauge that is not providing the Retries data.
The problem is now that the FT is using too old 'Gauge.CSharp.Lib' (that should be 0.10.1) and missing the updated constructor for 'executionContextScenarioType'. Where is the update point for FT project using the latest 'Gauge.CSharp.Lib'?

@PiotrNestor
Copy link
Contributor Author

PiotrNestor commented Mar 7, 2024

@sriv
LSP tests - there is some race condition in the build and run tests cycle.

Error: EPERM: operation not permitted, unlink 'C:\Users\runneradmin\AppData\Local\Temp\gauge-lsp-testanyjlL\gauge_bin\Gauge.CSharp.Lib.dll'

I don't understand why gauge_bin contains a C# dll for a JavaScript test run ...

@sriv sriv merged commit 33dc6ea into getgauge:master Mar 8, 2024
7 checks passed
@PiotrNestor PiotrNestor deleted the retries-info-in-context branch March 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseCandidate Pr that is eligible for a release
Development

Successfully merging this pull request may close these issues.

2 participants