Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scenario retries info params #2496

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

PiotrNestor
Copy link
Contributor

@PiotrNestor PiotrNestor commented Feb 29, 2024

@sriv

Support for scenario retries data in ExecutionInfo.
This provides scenario execution retries information in the hooks context.

This is used to decide if:

  • this is the normal scenario execution
  • this is a retry of the scenario execution. In this case it's used to possibly reset test data for the scenario.

Some other notes related to '--max-retries-count'

  • MaxRetries is '0' if '--max-retries-count' is not set
  • MaxRetries is 1 less than '--max-retries-count' if set
  • MaxRetries indicates the actual retry count
  • CurrentRetry is 0 for the first normal scenario execution

Related updates in:
https://github.com/system-verification/gauge-proto/tree/retries-info-in-context
https://github.com/system-verification/gauge-csharp-lib/tree/retries-info-in-context
https://github.com/system-verification/gauge-dotnet/tree/retries-info-in-context

The updated 'gauge' runner tested with unmodified plugin runners and reporters. These work OK

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@PiotrNestor
Copy link
Contributor Author

@sriv
Can we move forward with this feature?

@sriv
Copy link
Member

sriv commented Mar 5, 2024

yes, looks like a reasonable change proposal.

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@PiotrNestor PiotrNestor marked this pull request as ready for review March 5, 2024 12:49
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Benchmark Results

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
6475093 44% 243516 0:29.99 0
e1b8dd9 40% 237048 0:33.03 0
44ebad3 43% 241196 0:30.34 0
5168b89 37% 245380 0:36.73 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
6475093 51% 65716 0:11.90 0
e1b8dd9 53% 67896 0:11.58 0
44ebad3 48% 69940 0:12.77 0
5168b89 50% 67764 0:12.19 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
6475093 9% 117392 0:25.12 0
e1b8dd9 9% 120024 0:26.14 0
44ebad3 9% 121916 0:25.68 0
5168b89 9% 108936 0:25.11 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
6475093 30% 68364 0:12.14 0
e1b8dd9 34% 65960 0:10.23 0
44ebad3 25% 68024 0:14.01 0
5168b89 37% 67848 0:09.77 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
6475093 22% 72064 0:23.98 0
e1b8dd9 24% 72016 0:22.87 0
44ebad3 24% 71404 0:23.26 0
5168b89 25% 72088 0:22.03 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
6475093 9% 114264 0:23.61 0
e1b8dd9 10% 119588 0:22.49 0
44ebad3 9% 120368 0:23.62 0
5168b89 9% 116548 0:23.16 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
6475093 83% 260176 0:17.12 0
e1b8dd9 75% 234640 0:19.04 0
44ebad3 81% 233976 0:18.09 0
5168b89 76% 234516 0:19.00 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
6475093 5% 116668 0:46.13 0
e1b8dd9 5% 120188 0:41.12 0
44ebad3 5% 121144 0:45.50 0
5168b89 5% 117800 0:44.14 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
6475093 58% 202856 0:19.71 0
e1b8dd9 65% 245688 0:17.74 0
44ebad3 66% 210124 0:16.84 0
5168b89 59% 223232 0:19.17 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

execution/specExecutor.go Show resolved Hide resolved
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@gaugebot
Copy link

gaugebot bot commented Mar 11, 2024

@PiotrNestor Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@sriv sriv merged commit a550d71 into getgauge:master Mar 11, 2024
28 checks passed
@PiotrNestor PiotrNestor deleted the retries-info-in-context branch March 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants