#98 handle parameter mismatch

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
getgauge · Sep 28, 2020 · dcf7885 · dcf7885
1 parent 5cd2a06
commit dcf7885
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/gauge-global.js b/src/gauge-global.js
@@ -19,7 +19,7 @@ var step = function (stepName, options, stepFunction) {
   if (typeof stepName === "object" && !!stepName.length) {
     stepRegistry.addAlias(stepName, stepFunction, filepath, {}, options);
   } else if (typeof stepName === "string") {
-    stepRegistry.add(stepName, stepFunction, filepath, {}, options);
+    stepRegistry.add(stepName, stepFunction, null, filepath, {}, options);
   }
 };
 

diff --git a/src/static-loader.js b/src/static-loader.js
@@ -11,8 +11,8 @@ function hasAliases(node) {
   return node.type === "ArrayExpression" && !!node.elements.length;
 }
 
-function addStep(step, info) {
-  stepRegistry.add(step.value, null, info.filePath, info.span, null);
+function addStep(step, info, params) {
+  stepRegistry.add(step.value, null, params, info.filePath, info.span, null);
 }
 
 function addAliases(aliases, info) {
@@ -23,6 +23,7 @@ function addAliases(aliases, info) {
 
 function processNode(node, filePath) {
   var stepNode = node.arguments[0];
+  var stepFunc = node.arguments[1] ? node.arguments[1]: null;
   var span = {
     start: node.loc.start.line,
     end: node.loc.end.line,
@@ -33,7 +34,7 @@ function processNode(node, filePath) {
     if (hasAliases(stepNode)) {
       addAliases(stepNode.elements, { filePath: filePath, span: span });
     } else if (stepNode.type === "Literal") {
-      addStep(stepNode, { filePath: filePath, span: span });
+      addStep(stepNode, { filePath: filePath, span: span }, stepFunc ? stepFunc.params.length : null);
     }
   } catch (e) {
     logger.info(e);

diff --git a/src/step-registry.js b/src/step-registry.js
@@ -15,7 +15,7 @@ var StepRegistry = function () {
  * @param options Optional parameters defined with the step.
  * @returns The step added.
  */
-StepRegistry.prototype.add = function (stepText, stepFunction, filePath, span, options) {
+StepRegistry.prototype.add = function (stepText, stepFunction, stepFuncParams, filePath, span, options) {
   if (!stepText.length) {
     throw new Error("Step text cannot be empty.");
   }
@@ -27,6 +27,7 @@ StepRegistry.prototype.add = function (stepText, stepFunction, filePath, span, o
 
   this.registry[generalisedText] = {
     fn: stepFunction,
+    fnParamsCount: stepFuncParams,
     stepText: stepText,
     generalisedText: generalisedText,
     fileLocations: [
@@ -117,6 +118,9 @@ StepRegistry.prototype.validate = function (stepName) {
   if (!step) {
     return { valid: false, reason: "notfound", file: null };
   }
+  if (step.fnParamsCount !== stepParser.getParams(step.stepText).length) {
+    return { valid: false, reason: "parameter mismatch", file: step.fileLocations[0].filePath };
+  }
   if (step.fileLocations.length > 1) {
     return { valid: false, reason: "duplicate", file: step.fileLocations[0].filePath };
   }