Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter mismatch should be handled #98

Closed
sswaroopgupta opened this issue Jan 9, 2018 · 1 comment
Closed

Parameter mismatch should be handled #98

sswaroopgupta opened this issue Jan 9, 2018 · 1 comment
Assignees
@NivedhaSenthil
Labels
bug

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jan 9, 2018 •
edited
Loading

Expected behavior
If there is a parameter mismatch in the step and the implementation, it should be handled.

Actual behavior
The step is executed and times out.

Steps to replicate

  • Create a new gauge-js project
  • add a step one
  • generate implementation one
  • Now add a parameter to the method signature.
  • Run the specs

The step with the parameter mismatch times out

Version

Gauge version: 0.9.7.nightly-2018-01-08
Commit Hash: bc9784c

Plugins
-------
js (2.1.0.nightly-2018-01-08)
@sswaroopgupta sswaroopgupta mentioned this issue Jan 9, 2018
Closed
@sswaroopgupta sswaroopgupta mentioned this issue Mar 1, 2018
Closed
@NivedhaSenthil NivedhaSenthil self-assigned this Sep 28, 2020
NivedhaSenthil added a commit that referenced this issue Sep 28, 2020
@NivedhaSenthil
#98 handle parameter mismatch
dcf7885 
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue Sep 29, 2020
@NivedhaSenthil
#98 Error on arg length mismatch and timedout
6ccbb36 
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue Oct 12, 2020
@NivedhaSenthil
#98 Error on arg length mismatch and timedout (#397)
a1d858a 
* #98 Error on arg length mismatch and timedout

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* update arg mismatch message

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Bump  version to 2.3.13

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@NivedhaSenthil
Copy link
Member

fixed in 2.3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NivedhaSenthil NivedhaSenthil

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sswaroopgupta @NivedhaSenthil