Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics that need documenting... #356

Open
rhukster opened this issue Dec 15, 2016 · 38 comments
Open

Topics that need documenting... #356

rhukster opened this issue Dec 15, 2016 · 38 comments

Comments

@rhukster
Copy link
Member

rhukster commented Dec 15, 2016

These are some topics I have on my big-list-of-grav-things that need to get documented in the docs. Some are clarifications, some are new features that have been added to the Grav core and just not documented yet.

Please consider digging in and helping to knock these out. It's an easy way you can contribute back to Grav :)

Grav Core

Core Events

  • onPageFallbackUrl()

  • onFallbackUrl()

  • onMarkdownInitialized()

  • onMediaLocate()

  • onGetPageTemplates()

  • onGetPageBlueprints()

  • onTwigLoader

  • onActionX

  • onPageActionX

  • onTaskX

Admin Plugin

  • Document how to extend site.yaml and others with config blueprint override https://gist.github.com/rhukster/89429cc5738b9201c4fd5a6057fe1596

  • Document how to create and use a custom page blueprint to provide "Custom Page Types" functionality

  • Document how to create a custom field

  • Document the Dashboard and Notifications setting with explanation on how to stop the notifications requests to be sent by disabling the 4 places it's needed. (fix to in admin to support this is pending)

  • Document the volatile nature of APCu/Xcache and how you can't populate cache from CLI because these are destroyed after every CLI php call. File works best, but memcached/redis should also be fine (after Grav 1.1.16 which has the fix)

  • document not being able to scroll caused by cloudlare. Can't scroll on any of the admin panel pages grav-plugin-admin#808 (comment)

  • Update user profile screenshot documentation to mention user-uploadable avatar

  • Document new "Tools" menu option for direct install

  • Document fieldset form field for admin: Add fieldset form field grav-plugin-admin#210

  • Document parents field which extends pages - https://gist.github.com/rhukster/6df3bdb106e2b06242b10ae549e5e021

  • Document the security: option on Section and Tab field to limit access

  • Document the password REGEX requirements

  • Document $this->grav['twig']->plugins_quick_tray via onAdminMenu event

  • Document icon quick-tray and how to use it in plugins

  • Mention offline mode?

  • Document multilevel and mediapicker field

Admin Events

  • onAdminTaskExecute()

  • onAdminCreatePageFrontmatter()

  • onAdminAfterSave

  • onAdminAfterSaveAs

  • onAdminAfterDelete

  • onAdminAfterMedia

  • onAdminAfterDelMedia

Forms

Cookbook

  • Tutorial on how to create a split menu system (vertical menu?)

  • Tutorial on how to create a split menu system (vertical menu?)

  • Tutorial walkthrough covering going from and HTML site/design to Grav theme

  • Tutorial walkthrough covering going from and HTML site/design to Grav theme

  • How to add a page specific CSS file via a custom page template - block stylesheets, parent(), then {% do assets.addCss('theme://css/custom-page.css') %}

  • Add simple CSS stylesheet to the simple gallery example.

  • Simple plugin/events to get all users in accounts/ and add them as a twig variable for use on frontend.

  • Custom select field - How to add whole countries select list in grav forms grav-plugin-form#187 (comment)

  • Document not being able to scroll caused by cloudlare. Can't scroll on any of the admin panel pages grav-plugin-admin#808 (comment)

Hosting

  • Tutorial on best custom hosting with VPS + Serverpilot.io

  • Add Runcloud to Hosting?

@RyanMPierson
Copy link
Member

onPageFallBackURL was documented: 6915ed6

@RyanMPierson
Copy link
Member

htaccess documented: 8d168d1

@RyanMPierson
Copy link
Member

Expanded on System Config documentation: ac42d1d

RyanMPierson added a commit that referenced this issue Jan 27, 2017
RyanMPierson added a commit that referenced this issue Feb 8, 2017
@RyanMPierson
Copy link
Member

@OleVik
Copy link
Contributor

OleVik commented Feb 27, 2017

In regards to "Cookbook" -> "Tutorial on how to create a split menu system (vertical menu?)", is the idea to split menu items by category, subcategory, and item? Ie., a hierarchical menu.

@OleVik OleVik mentioned this issue Feb 27, 2017
kmcital added a commit to kmcital/grav-learn that referenced this issue Feb 27, 2017
I forgot to add before submitting that PR, but really think a link to the page object details in the theme variable section is much needed here. I remember that was hard to find at first. Also, completed documentation task in getgrav#356.
rhukster pushed a commit that referenced this issue Feb 27, 2017
I forgot to add before submitting that PR, but really think a link to the page object details in the theme variable section is much needed here. I remember that was hard to find at first. Also, completed documentation task in #356.
@OleVik OleVik mentioned this issue Feb 27, 2017
@rhukster rhukster reopened this Feb 27, 2017
@rhukster
Copy link
Member Author

In regards to the split menu cookbook entry @OleVik, what i had in mind was the main menu shows only the 1st level items. Then when you click on say 'services' top level, and it has a series of items under there: 'consulting', ' development', etc, those show up underneath as a horizontal menu. This is what I consider a 2 level split-menu.

@RyanMPierson
Copy link
Member

Dashboard options documented: https://learn.getgrav.org/admin-panel/plugin-options

@RyanMPierson
Copy link
Member

Documented Tools Menu Option for Direct Install: https://learn.getgrav.org/admin-panel/tools

rhukster pushed a commit that referenced this issue May 12, 2017
Includes
* #356: Added inline CSS and JS via Asset manager getgrav/grav#1377
* Add missing documentation on configuration options
* Add an overview section
* Move "Static Assets" to the bottom
@hughbris
Copy link
Contributor

hughbris commented Apr 2, 2018

  • Explain what media thumbnail options page, default, and media actually do/mean

default seems to be the default thumbnail from system folder for media type e.g. /system/images/media/thumb-jpg.png

page is taken from the media folder with pattern [media-name].[media-extension].thumb.[thumb-extension], and seems to fall back to the media itself

media is the (image) medium itself

@RyanMPierson
Copy link
Member

Offline Mode Documented d473200

RyanMPierson pushed a commit that referenced this issue Jun 21, 2018
@hughbris
Copy link
Contributor

hughbris commented Jul 11, 2018

Update: decent examples are provided under blueprints as it happens. Having missed this completely when I needed it, perhaps we should be talking about better cross-referencing of shared content between the blueprints and user forms sections.

@OleVik
Copy link
Contributor

OleVik commented Jul 15, 2018

On my wishlist:

@mahagr and @RyanMPierson know a lot about this process, and I imagine there are some underused abilities of blueprints that would allow for easier debugging of structure and implementation, which is a sticky, reoccurring issue people ask for help with.

OleVik added a commit to OleVik/grav-learn that referenced this issue Jul 15, 2018
- [x] Document optional collection ordering PHP flags getgrav/grav#1640
	- Added under /content/collections#php-collections
- [x] Added cache_control system and page override getgrav/grav#1591
	- Added reference-link to /basics/grav-configuration#pages
	- Added /content/headers#cache-control
- [x] clear_images_by_default cache option getgrav/grav#1481
	- Clarified description in /basics/grav-configuration#pages
- [x] Collection::intersect() getgrav/grav#1605
	- Added under /content/collections#collection-object-methods
- [x] Collection::merge() method
	- Added under /content/collections#collection-object-methods
- [x] Page::collection() filtering
	- Added under /content/collections#complex-collections, with a bit of cleanup
- [x] Document EXIF support in Grav (and in capabilities)
	- Clarified /themes/twig-filters-functions#exif
	- Added note at the end of /cookbook/general-recipes#creating-a-simple-gallery
- [x] document not being able to scroll caused by cloudlare. getgrav/grav-plugin-admin#808 (comment)
	- Done in getgrav#397
	- Duplicated under Admin Plugin and Cookbook headers
- [x] Document adding custom form fields with examples..
	- Done in getgrav#401
- [x] Document range field
	- Done in [7e0dcbc](getgrav@7e0dcbc)
- [x] Tutorial on how to create a split menu system (vertical menu?)
	- Duplicated under Cookbook header
- [x] Tutorial walkthrough covering going from and HTML site/design to Grav theme
	- Duplicated under Cookbook header

getgrav#356 needs some cleanup to remove completed tasks, they're not really needed.
RyanMPierson added a commit that referenced this issue Jul 15, 2018
@RyanMPierson
Copy link
Member

Added CloudFlare workaround via getgrav/grav-plugin-admin#808 (comment)

RyanMPierson added a commit that referenced this issue Jul 15, 2018
hughbris added a commit to hughbris/grav-learn that referenced this issue Jul 23, 2018
@hughbris
Copy link
Contributor

hughbris commented Jul 24, 2018

rhukster pushed a commit that referenced this issue Jul 27, 2018
rhukster pushed a commit that referenced this issue Jul 27, 2018
- [x] Document optional collection ordering PHP flags getgrav/grav#1640
	- Added under /content/collections#php-collections
- [x] Added cache_control system and page override getgrav/grav#1591
	- Added reference-link to /basics/grav-configuration#pages
	- Added /content/headers#cache-control
- [x] clear_images_by_default cache option getgrav/grav#1481
	- Clarified description in /basics/grav-configuration#pages
- [x] Collection::intersect() getgrav/grav#1605
	- Added under /content/collections#collection-object-methods
- [x] Collection::merge() method
	- Added under /content/collections#collection-object-methods
- [x] Page::collection() filtering
	- Added under /content/collections#complex-collections, with a bit of cleanup
- [x] Document EXIF support in Grav (and in capabilities)
	- Clarified /themes/twig-filters-functions#exif
	- Added note at the end of /cookbook/general-recipes#creating-a-simple-gallery
- [x] document not being able to scroll caused by cloudlare. getgrav/grav-plugin-admin#808 (comment)
	- Done in #397
	- Duplicated under Admin Plugin and Cookbook headers
- [x] Document adding custom form fields with examples..
	- Done in #401
- [x] Document range field
	- Done in [7e0dcbc](7e0dcbc)
- [x] Tutorial on how to create a split menu system (vertical menu?)
	- Duplicated under Cookbook header
- [x] Tutorial walkthrough covering going from and HTML site/design to Grav theme
	- Duplicated under Cookbook header

#356 needs some cleanup to remove completed tasks, they're not really needed.
@rhukster rhukster pinned this issue Feb 25, 2019
@NicoHood
Copy link
Contributor

NicoHood commented Dec 2, 2020

The message API is not documented or mentioned anywhere:

$this->grav['messages']->add($message, 'warning');

@NicoHood
Copy link
Contributor

NicoHood commented Dec 2, 2020

grav.user.access.admin.login Is undocumented (used to check if the admin panel is opened or not, equivalent to $this->isAdmin().

Should be added here:
https://learn.getgrav.org/16/themes/theme-vars#user-object

--> I've document this thing, however I dont know what else the object is used for, maybe there are other permissions worth to document. Also I dont know if this is still valid for 1.7.

@mahagr
Copy link
Member

mahagr commented Dec 4, 2020

Above does not work, it never has. You should not be using grav.user.access for anything, it is just a raw list of user access and there is a method to get the same information in a normalized format. Also, it is not $this->isAdmin(), not even close (which checks if admin plugin is active).

@NicoHood
Copy link
Contributor

GRAV_VERSION is not documented:
getgrav/grav#3142

@james0r
Copy link
Contributor

james0r commented Jun 24, 2022

From a suggestion I made in the Discord server:

I'm seeing the blueprint admin fields available in the docs, then if we want to find text field information we have to navigate to frontend fields, I think it would be best to just list all fields that are available for the admin and create another table column to denote which ones are only available in the admin. That way the dev doesn't have to navigate back and forth from frontend/admin fields. Something like this:

admin-fields-suggestion

I was told this was the case before but that there were "issues". I'd be interested to know if they couldn't be addressed while still, what I feel is improving this page.

@NoNoNo
Copy link

NoNoNo commented Jul 25, 2023

In images.defaults (in config system.yaml), you can list methods, that get called by default on object of class Grav\Common\Page\Medium\Medium, e.g.

images.defaults.derivatives: '320, 3200, 320' will invoke derivatives(320, 3200, 320)

https://github.com/getgrav/grav/blob/490bdd6ce7aaae315c033ca5af112a778a42455a/system/src/Grav/Common/Page/Markdown/Excerpts.php#L283-L306

This feature should be documented in https://learn.getgrav.org/17/basics/grav-configuration#images

@rhukster
Copy link
Member Author

Please submit a pull request by clicking "edit" button on the docs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests