Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to pass an array of explicit widths to ImageMedium#derivatives #1133

Merged
merged 2 commits into from
Dec 2, 2016

Conversation

fredrikekelund
Copy link
Contributor

Allows for more precise control than the min-width, max-width and step parameters. As previously discussed in #1051.

…vatives

Allows for more precise control than the min-width, max-width and
step parameters.
Copy link
Member

@rhukster rhukster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide me a test example so i can properly test it?

… as well

Previously it was only possible from Twig code or PHP code
@fredrikekelund
Copy link
Contributor Author

@rhukster it used to be pretty straightforward in Twig or PHP, but I realized that specifying an array as a function argument wasn't Markdown compatible, so I pushed a commit to fix that. Now, testing it should be a simple as doing this in a page's Markdown:

![](test.jpg?derivatives=[640,1500,2500])

@rhukster
Copy link
Member

Ok thanks, will test this shortly!

@rhukster
Copy link
Member

Sorry for the delay, I have been uber busy. Will test this during the upcoming holiday. Cheers.

@rhukster rhukster merged commit 36428e4 into getgrav:develop Dec 2, 2016
@rhukster
Copy link
Member

rhukster commented Dec 2, 2016

I got it tested and looks good! Thanks, merged.

rhukster pushed a commit to getgrav/grav-learn that referenced this pull request Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants