Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[First time launching Gravy] Register admin form does not give clues about what's wrong with wrong email #1129

Closed
BoQsc opened this issue Jun 7, 2017 · 1 comment
Closed

[First time launching Gravy] Register admin form does not give clues about what's wrong with wrong email #1129

BoQsc opened this issue Jun 7, 2017 · 1 comment
Labels
fixed

Comments

@BoQsc
Copy link

BoQsc commented Jun 7, 2017 •
edited
Loading

I did type "admin@localhost" and registration form didn't give any clues about what's wrong with it.
A thing I thought about: maybe the password isn't matching before I arrive at a conclusion that email was incorrectly typed.
@flaviocopes
Copy link
Contributor

Thanks for reporting, there is HTML frontend validation in the form, but admin@localhost passes that. It does not pass the server-side validation, but the error message does not appear. Looking to improve that.

flaviocopes added a commit that referenced this issue Jun 8, 2017
@flaviocopes
If a form is already defined, do not override it
d37a228 
Preserves form validation re
#1129
@flaviocopes flaviocopes mentioned this issue Jun 8, 2017
Merged
@rhukster rhukster added the bug label Jul 26, 2017
rhukster pushed a commit that referenced this issue Jul 26, 2017
@flaviocopes @rhukster
If a form is already defined, do not override it (#1132)
05a6abd 
Preserves form validation re
#1129
@rhukster rhukster mentioned this issue Jul 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhukster @flaviocopes @BoQsc