Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a form is already defined, do not override it #1132

Merged
merged 1 commit into from
Jul 26, 2017
Merged

If a form is already defined, do not override it #1132

merged 1 commit into from
Jul 26, 2017

Conversation

flaviocopes
Copy link
Contributor

Preserves form validation re
#1129

rhukster
rhukster requested changes Jun 27, 2017
View reviewed changes
Copy link
Member

@rhukster rhukster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be fine if if the twig var was also checked to be an instance of Form (just to be safer)

@rhukster rhukster merged commit 05a6abd into develop Jul 26, 2017
@rhukster
Copy link
Member

Actually after testing, this fine as-is. cheers @flaviocopes !

@rhukster rhukster deleted the feature/preserve-form-validation branch October 1, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhukster rhukster rhukster requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaviocopes @rhukster