-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] Panel NetworkError doens't disappear when coming back online #5821
Comments
Note for us: NetworkError is uncaught - which causes a regular error dialog. Not our offline warning component that reacts on |
This is probably caused by the lock requests. I think we should stop those when the panel is offline |
Maybe easier not to stop the interval but only wrap the actual api call in an if statement checking for not offline |
I still get sometimes the error "NetworkError when attempting to fetch resource" |
@chrfickinger does it still happen to you in the latest rc? |
I'm not on the latest rc yet, but I haven't seen the error again |
Description
When I put my computer to sleep and later come back I often have to dismiss an error modal with the following message:
"NetworkError when attempting to fetch resource."
Expected behavior
I'd expect the modal to disappear on it's own once I'm back online.
Screenshots
![Screenshot 2023-10-19 at 11 59 22](https://private-user-images.githubusercontent.com/60777/276572993-1b3a1fc8-0016-42fc-9b11-328e81428da8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODUzNTAsIm5iZiI6MTczOTM4NTA1MCwicGF0aCI6Ii82MDc3Ny8yNzY1NzI5OTMtMWIzYTFmYzgtMDAxNi00MmZjLTliMTEtMzI4ZTgxNDI4ZGE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE4MzA1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNiZTJjYzBlYTc0MzhiZmQ0MTQyN2I4NTNlNjAwNGQ5NDcxNTkwMzdkZDFmYzNlYzk3ZjNkM2MxMTU0MzEzMDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fCAXhRaPQnS0w4sKOVKfvA34n1dNDzdS8Lwxh-UTpG0)
Your setup
Kirby Version
4.0.0-alpha.7
Console output
The text was updated successfully, but these errors were encountered: