Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Panel NetworkError doens't disappear when coming back online #5821

Closed
mrflix opened this issue Oct 19, 2023 · 6 comments · Fixed by #5890
Closed

[v4] Panel NetworkError doens't disappear when coming back online #5821

mrflix opened this issue Oct 19, 2023 · 6 comments · Fixed by #5890
Assignees
Milestone

Comments

@mrflix
Copy link
Contributor

mrflix commented Oct 19, 2023

Description

When I put my computer to sleep and later come back I often have to dismiss an error modal with the following message:

"NetworkError when attempting to fetch resource."

Expected behavior
I'd expect the modal to disappear on it's own once I'm back online.

Screenshots
Screenshot 2023-10-19 at 11 59 22

Your setup

Kirby Version
4.0.0-alpha.7

Console output

Uncaught (in promise) TypeError: NetworkError when attempting to fetch resource.

@distantnative
Copy link
Member

Note for us: NetworkError is uncaught - which causes a regular error dialog. Not our offline warning component that reacts on window.offline/window.online. Thus, it'll stick around as normal error dialog.

@bastianallgeier
Copy link
Member

bastianallgeier commented Oct 20, 2023

This is probably caused by the lock requests. I think we should stop those when the panel is offline

@distantnative
Copy link
Member

Maybe easier not to stop the interval but only wrap the actual api call in an if statement checking for not offline

@distantnative distantnative self-assigned this Oct 29, 2023
distantnative added a commit that referenced this issue Oct 29, 2023
@distantnative distantnative added this to the 4.0-beta.3 milestone Oct 29, 2023
@distantnative distantnative linked a pull request Oct 29, 2023 that will close this issue
@chrfickinger
Copy link

I still get sometimes the error "NetworkError when attempting to fetch resource"
(4.0-beta.3)

@bastianallgeier
Copy link
Member

@chrfickinger does it still happen to you in the latest rc?

@chrfickinger
Copy link

I'm not on the latest rc yet, but I haven't seen the error again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants