Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop lock requests when offline #5890

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Stop lock requests when offline #5890

merged 1 commit into from
Oct 30, 2023

Conversation

distantnative
Copy link
Member

This PR …

Fixes

Enhancements

  • New panel.isOffline state
  • Checking and writing content lock is skipped when Panel is offline

@distantnative distantnative added this to the 4.0-beta.3 milestone Oct 29, 2023
@distantnative distantnative requested a review from a team October 29, 2023 14:09
@distantnative distantnative linked an issue Oct 29, 2023 that may be closed by this pull request
[v4] Panel NetworkError doens't disappear when coming back online #5821
Closed
bastianallgeier
bastianallgeier approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

@bastianallgeier bastianallgeier merged commit 12ca0c7 into v4/develop Oct 30, 2023
@bastianallgeier bastianallgeier deleted the v4/fix/5821-offline-lock-requests branch October 30, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
4.0-beta.3
Development

Successfully merging this pull request may close these issues.

[v4] Panel NetworkError doens't disappear when coming back online
2 participants
@distantnative @bastianallgeier