Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k-coloroptions-input #5696

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Sep 25, 2023

Features

  • New k-coloroptions-input

Screenshot 2023-09-25 at 16 46 43

The new input is used as foundation for the color field and the k-colorpicker-input, but can now also be used on its own.

<k-coloroptions-input :options="options" :value="value=" @input="value = $event" />

@bastianallgeier bastianallgeier requested a review from a team September 25, 2023 14:47
@bastianallgeier bastianallgeier changed the base branch from main to v4/develop September 25, 2023 14:50
@distantnative distantnative force-pushed the v4/refactor/coloroptions-input branch from 4299a2c to 878e6db Compare September 25, 2023 16:07
@distantnative
Copy link
Member

@bastianallgeier keyboard navigation seems broken, I can only reach the first or last option (depending if focus tabbing forward or backwards).

@bastianallgeier
Copy link
Member Author

It's a radio input. Once you set the focus, choice is made with arrow keys.

@distantnative
Copy link
Member

Ahh ok that wasn't quite that obvious. Though e.g. on https://sandbox.test/panel/pages/fields+color?tab=options navigating with arrow keys will jump between different fields.

@distantnative
Copy link
Member

It's due to the missing name.
I think we once need to pass a name where possible but also fall back to a uuid if no name is passed.

@bastianallgeier bastianallgeier force-pushed the v4/refactor/coloroptions-input branch from 7a33f13 to bf56e8e Compare September 26, 2023 08:27
@bastianallgeier
Copy link
Member Author

I've rebased it on v4/develop and added the _uid if there's no name

@distantnative
Copy link
Member

@bastianallgeier Should we pass the name in the colorfield context?

@bastianallgeier
Copy link
Member Author

@distantnative yes, definitely makes sense!

@bastianallgeier bastianallgeier added this to the 4.0.0-beta.2 milestone Sep 26, 2023
@distantnative
Copy link
Member

Shouldn't there be some visual indication when the input is focussed? That's currently missing (which then feels like the focus just disappeared).

@bastianallgeier
Copy link
Member Author

@distantnative ☑️

@bastianallgeier bastianallgeier merged commit 182e650 into v4/develop Sep 27, 2023
@bastianallgeier bastianallgeier deleted the v4/refactor/coloroptions-input branch September 27, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants