-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k-coloroptions-input #5696
k-coloroptions-input #5696
Conversation
4299a2c
to
878e6db
Compare
@bastianallgeier keyboard navigation seems broken, I can only reach the first or last option (depending if focus tabbing forward or backwards). |
It's a radio input. Once you set the focus, choice is made with arrow keys. |
Ahh ok that wasn't quite that obvious. Though e.g. on https://sandbox.test/panel/pages/fields+color?tab=options navigating with arrow keys will jump between different fields. |
It's due to the missing name. |
7a33f13
to
bf56e8e
Compare
I've rebased it on v4/develop and added the _uid if there's no name |
@bastianallgeier Should we pass the name in the colorfield context? |
@distantnative yes, definitely makes sense! |
Shouldn't there be some visual indication when the input is focussed? That's currently missing (which then feels like the focus just disappeared). |
Features
k-coloroptions-input
The new input is used as foundation for the color field and the k-colorpicker-input, but can now also be used on its own.