Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all tests working with latest botocore #1907

Merged
merged 3 commits into from
Nov 4, 2018
Merged

Get all tests working with latest botocore #1907

merged 3 commits into from
Nov 4, 2018

Conversation

lhufnagel
Copy link

This is a rebased version of #1847 including this commit

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 92.496% when pulling b20e190 on lhufnagel:rebased_pr into 71a054a on spulec:master.

@lhufnagel
Copy link
Author

Hm, looks like policy() in LambdaResponses is not tested in server mode..

@spulec
Copy link
Collaborator

spulec commented Nov 4, 2018

Thanks for all of the work @lhufnagel !

@jrideout
Copy link

jrideout commented Nov 5, 2018

I tried upgrading to 1.3.7 and found some sort of issue with the monkey patching that occurs only when other tests (without moto) are run first. I suspect something is getting imported that prevents the patching. When I run just test files with moto imported, they all pass. When I run my whole test suite, or even just two files (one without moto, but that still imports some of our project that has boto3 imports), provided the test without moto runs first, the moto tests will fail with IAM permission issues.

@pzhongp
Copy link

pzhongp commented Nov 6, 2018

I am still seeing error:
botocore.exceptions.ClientError: An error occurred (InvalidAccessKeyId) when calling the CreateBucket operation: The AWS Access Key Id you provided does not exist in our records.

Version I am using:
boto==2.49.0
boto3==1.9.38
botocore==1.12.38
moto==1.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants