gh-pages fixes #240
gh-pages fixes #240
Conversation
| @@ -111,7 +111,7 @@ jobs: | |||
| git config user.email "fx-data-platform@mozilla.com" | |||
| git config user.name "CircleCI docs-deploy job" | |||
| npm install -g --silent gh-pages@2.0.1 | |||
| gh-pages -d docs/_build/html | |||
| gh-pages --dotfiles --message "[skip ci] Updates" --dist docs/_build/html | |||
There was a problem hiding this comment.
The --dotfiles flag is necessary for the .nojekyll file to get committed. The [skip ci] message prevents CircleCI from trying to build the gh-pages branch after this commit (which we expect to fail because it doesn't have the source code).
tox.ini
Outdated
| # TODO: Remove this once moto restores compatibility | ||
| deps = | ||
| boto3==1.7.84 | ||
|
|
There was a problem hiding this comment.
The moto issue is now fixed, so we can remove this restriction.
|
Spoke too soon on the moto fix. I'm investigating now. |
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 11 11
Lines 1053 1053
=======================================
Hits 843 843
Misses 210 210
Continue to review full report at Codecov.
|
| boto3==1.7.84 | ||
| setenv = | ||
| AWS_SECRET_ACCESS_KEY=dummy_secret_needed_for_moto_tests | ||
| AWS_ACCESS_KEY_ID=dummy_key_needed_for_moto_tests |
There was a problem hiding this comment.
Follows new example in getmoto/moto#1907
Just a few more changes to fix observed problems with docs and CI