Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ping/pong mechanism with practical debugging. #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kybird
Copy link

@kybird kybird commented Jul 17, 2023

if you unplug ethernet cable. current implementation can't detect it
this fix will proper check it according to configuration of ping_timeout and ping_interval.
anyway i am not sure what exactly original intention. this is just my implement by test with socket.io latest version. 4.6.1

@getnamo
Copy link
Owner

getnamo commented Sep 26, 2023

This is a bit risky change so I will schedule a proper testing round for it a bit later to test merge viability. Will need to ensure we don't get regression in expected behavior before merging.

@kybird
Copy link
Author

kybird commented Sep 27, 2023

yes, it is.. i just concentrate on resolve the issue that is plug off the ethernet cable. current implementation can't recognize at least on my environment. base on testing environment and without understanding the base logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants