Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: remove redundant indices from submission_defs table #805

Merged
merged 3 commits into from
Apr 24, 2023
Merged

enhance: remove redundant indices from submission_defs table #805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f4f177
enhance: remove redundant indices from submission_defs table
sadiqkhoja Mar 21, 2023
1a2eba8
remove redundant indices from submissions table
sadiqkhoja Apr 19, 2023
33da5fc
rename migration file to current date
sadiqkhoja Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions lib/model/migrations/20230419-01-optimize-indices-sub-defs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// Copyright 2023 ODK Central Developers
// See the NOTICE file at the top-level directory of this distribution and at
// https://github.com/getodk/central-backend/blob/master/NOTICE.
// This file is part of ODK Central. It is subject to the license terms in
// the LICENSE file found in the top-level directory of this distribution and at
// https://www.apache.org/licenses/LICENSE-2.0. No part of ODK Central,
// including this file, may be copied, modified, propagated, or distributed
// except according to the terms contained in the LICENSE file.

const up = async (db) => {
// removing redundant indices from submissions
await db.raw('DROP INDEX public.submissions_draft_index;');
await db.raw('DROP INDEX public.submissions_formid_index;');
await db.raw('DROP INDEX public.submissions_formid_instanceid_index;');
await db.raw('DROP INDEX public.submissions_formid_createdat_index;');
// because we sort by createdAt, id for get and exports
await db.raw('CREATE INDEX submissions_formid_createdat_id_index ON public.submissions USING btree ("formId", "createdAt", id);');
lognaturel marked this conversation as resolved.
Show resolved Hide resolved

// removing redundant indices from submission_defs
await db.raw('DROP INDEX public.submission_defs_createdat_index;');
await db.raw('DROP INDEX public.submission_defs_current_index;');
await db.raw('DROP INDEX public.submission_defs_id_submissionid_index;');
await db.raw('DROP INDEX public.submission_defs_submissionid_index;');
// because we sort by createdAt, id for client audit export
await db.raw('CREATE INDEX submission_defs_createdat_id_index ON public.submission_defs USING btree ("createdAt", id);');
lognaturel marked this conversation as resolved.
Show resolved Hide resolved
};

const down = async (db) => {
await db.raw('CREATE INDEX submissions_draft_index ON public.submissions USING btree (draft);');
await db.raw('CREATE INDEX submissions_formid_index ON public.submissions USING btree ("formId");');
await db.raw('CREATE INDEX submissions_formid_instanceid_index ON public.submissions USING btree ("formId", "instanceId");');
await db.raw('CREATE INDEX submissions_formid_createdat_index ON public.submissions USING btree ("formId", "createdAt");');
await db.raw('DROP INDEX public.submissions_formid_createdat_id_index;');


await db.raw('CREATE INDEX submission_defs_createdat_index ON public.submission_defs USING btree ("createdAt");');
await db.raw('CREATE INDEX submission_defs_current_index ON public.submission_defs USING btree (current);');
await db.raw('CREATE INDEX submission_defs_id_submissionid_index ON public.submission_defs USING btree (id, "submissionId");');
await db.raw('CREATE INDEX submission_defs_submissionid_index ON public.submission_defs USING btree ("submissionId");');
await db.raw('DROP INDEX public.submission_defs_createdat_id_index;');
};

module.exports = { up, down };