test/check-scripts: add checks to standardise whitespace #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespace changes are often introduced inadvertently due to different editor configurations. They then add noise to PRs, and if committed, add noise to future diffs and the git log. This PR adds checks for the following in `.sh` files: * trailing spaces on lines * trailing newlines in files * tabs vs spaces
matthew-white
approved these changes
Feb 20, 2025
added 2 commits
February 21, 2025 10:15
matthew-white
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incidental to #891.
Whitespace changes can be introduced inadvertently due to different editor configurations. These changes then add noise to PRs, and if committed, add noise to future diffs and the git log.
This PR adds checks for the following in
.shfiles:What has been done to verify that this works as intended?
Added new tests!
Why is this the best possible solution? Were any other approaches considered?
The status quo could be maintained.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)