test/check-scripts: add checks to standardise whitespace

files/enketo/generate-secrets.sh

@@ -11,4 +11,3 @@ fi
 if [ ! -f /etc/secrets/enketo-api-key ]; then
   LC_ALL=C tr -dc '[:alnum:]' < /dev/urandom | head -c128 > /etc/secrets/enketo-api-key
 fi
-

files/prebuild/write-version.sh

@@ -1,4 +1,3 @@
 #!/bin/sh
 
 { echo "versions:"; echo "$(git rev-parse HEAD) ($(git describe --tags))"; git submodule; } > /tmp/version.txt
-

files/service/scripts/process-backlog.sh

@@ -2,4 +2,3 @@
 
 cd /usr/odk
 /usr/local/bin/node lib/bin/process-backlog.js >/proc/1/fd/1 2>/proc/1/fd/2
-

files/service/scripts/purge.sh

@@ -2,4 +2,3 @@
 
 cd /usr/odk
 /usr/local/bin/node lib/bin/purge.js >/proc/1/fd/1 2>/proc/1/fd/2
-

files/service/scripts/reap-sessions.sh

@@ -2,4 +2,3 @@
 
 cd /usr/odk
 /usr/local/bin/node lib/bin/reap-sessions.js >/proc/1/fd/1 2>/proc/1/fd/2
-

files/service/scripts/run-analytics.sh

@@ -2,4 +2,3 @@
 
 cd /usr/odk
 /usr/local/bin/node lib/bin/run-analytics.js >/proc/1/fd/1 2>/proc/1/fd/2
-

files/service/scripts/start-odk.sh

@@ -77,4 +77,3 @@ echo "using $WORKER_COUNT worker(s) based on available memory ($MEMTOT).."
 
 echo "starting server."
 exec npx pm2-runtime ./pm2.config.js
-

test/check-scripts.sh

@@ -6,6 +6,37 @@ log() { echo >&2 "[$(basename "$0")] $*"; }
 
 scriptFiles="$(cat <(git grep -El '^#!.*sh\b') <(git ls-files | grep -E '.sh$') | sort -u)"
 
+for script in $scriptFiles; do
+  log "Checking $script ..."
+
+  log "  Checking trailing whitespace on lines..."
+  if grep -E '\s+$' "$script"; then
+    log "    !!! Whitespace found at end of line !!!"
+    exit 1
+  fi
+  log "    Passed OK."
+
+  log "  Checking trailing newline in files..."
+  if [[ -n "$(tail -c 1 < "$script")" ]]; then
+    log "    !!! Missing final newline !!!"
+    exit 1
+  fi
+  if [[ -z "$(tail -c 2 < "$script")" ]]; then
+    log "    !!! Blank lines at end of file !!!"
+    exit 1
+  fi
+  log "    Passed OK."
+
+  log "  Checking for tab-based indentation..."
+  if grep $'\t' "$script"; then
+    log "    !!! Tab(s) found."
+    log "    !!!"
+    log "    !!! Please use spaces for indentation."
+    exit 1
+  fi
+  log "    Passed OK."
+done
+
 log "Running shellcheck..."
 echo "$scriptFiles" | xargs \
     shellcheck \

test/nginx/run-tests.sh

@@ -23,7 +23,7 @@ wait_for_http_response() {
     printf >&2 '❌\n'
     log "!!! URL timed out: $url"
     exit 1
-  fi  
+  fi
 }
 
 log "Starting test services..."