Update PR checklists #1861
Merged
Update PR checklists #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify the checklist items for the author * Add checklist items for the reviewer Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Jan 12, 2022
carolynvs
added a commit
to carolynvs/porter
that referenced
this pull request
Feb 7, 2022
* Merge pull request getporter#1884 from carolynvs/blog-secret * Merge pull request getporter#1891 from carolynvs/survey * Blog: IgnoreErrors and Az group command (getporter#1854) * Merge pull request getporter#1871 from carolynvs/heading-spa * Merge pull request getporter#1861 from carolynvs/pr-checklis * Merge pull request getporter#1850 from carolynvs/link-v1-doc * Merge pull request getporter#1847 from mikebarkas/1845--anch * 1757 completion command (getporter#1844) * Merge pull request getporter#1839 from carolynvs/status-badg * docs: 1841 Fix typo and align template divs (getporter#1842) Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
What issue does it fix
I keep forgetting to run some manual tests before merging then regret my life choices.
Notes for the reviewer
Anything else that we should prompt people about?
Checklist
If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️