Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce heading whitespace on blog posts #1871

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

carolynvs
Copy link
Member

What does this change

The blog posts have too much whitespace right now before H2 tags, which splits up the page oddly. This removes the extra space, just for blog posts.

What issue does it fix

NA

Notes for the reviewer

I could reduce the space even further because there is another padding statement that is adding padding to h2. That would impact ALL h2 tags on both blog posts and doc pages, not just the ones on the blog. What do you think?

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

The blog posts have too much whitespace right now before H2 tags, which
splits up the page oddly. This removes the extra space, just for blog
posts.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

carolynvs commented Jan 25, 2022

Example of the extra space between headings

Current Page: https://porter.sh/blog/v1-alpha3/
Screen Shot 2022-01-25 at 5 19 43 PM

Reduced whitespace
screenshot

Browser metadata
Path:      /blog/v1-alpha3/
Browser:   Firefox 95.0 on Mac OS 10.15
Viewport:  2109 x 1179 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@carolynvs carolynvs marked this pull request as ready for review January 25, 2022 23:20
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The current heading space on the doc pages doesn't look too big for me. Have we thought about removing the added paddings for the global h2 and let each component has its own header padding defined?

@carolynvs
Copy link
Member Author

@VinozzZ I am not sure that I am following what you are suggesting. If you want to open a PR and demonstrate what you are suggesting that would be great.

Copy link
Contributor

@joshuabezaleel joshuabezaleel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix Carolyn!

@carolynvs carolynvs merged commit 63f8ac3 into getporter:main Jan 27, 2022
@carolynvs carolynvs deleted the heading-space branch January 27, 2022 13:44
carolynvs added a commit to carolynvs/porter that referenced this pull request Feb 7, 2022
* Merge pull request getporter#1884 from carolynvs/blog-secret
* Merge pull request getporter#1891 from carolynvs/survey
* Blog: IgnoreErrors and Az group command (getporter#1854)
* Merge pull request getporter#1871 from carolynvs/heading-spa
* Merge pull request getporter#1861 from carolynvs/pr-checklis
* Merge pull request getporter#1850 from carolynvs/link-v1-doc
* Merge pull request getporter#1847 from mikebarkas/1845--anch
* 1757  completion command (getporter#1844)
* Merge pull request getporter#1839 from carolynvs/status-badg
* docs: 1841 Fix typo and align template divs (getporter#1842)

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs mentioned this pull request Feb 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants