-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce heading whitespace on blog posts #1871
Conversation
The blog posts have too much whitespace right now before H2 tags, which splits up the page oddly. This removes the extra space, just for blog posts. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Example of the extra space between headings Current Page: https://porter.sh/blog/v1-alpha3/ Browser metadata
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current heading space on the doc pages doesn't look too big for me. Have we thought about removing the added paddings for the global h2
and let each component has its own header padding defined?
@VinozzZ I am not sure that I am following what you are suggesting. If you want to open a PR and demonstrate what you are suggesting that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the fix Carolyn!
* Merge pull request getporter#1884 from carolynvs/blog-secret * Merge pull request getporter#1891 from carolynvs/survey * Blog: IgnoreErrors and Az group command (getporter#1854) * Merge pull request getporter#1871 from carolynvs/heading-spa * Merge pull request getporter#1861 from carolynvs/pr-checklis * Merge pull request getporter#1850 from carolynvs/link-v1-doc * Merge pull request getporter#1847 from mikebarkas/1845--anch * 1757 completion command (getporter#1844) * Merge pull request getporter#1839 from carolynvs/status-badg * docs: 1841 Fix typo and align template divs (getporter#1842) Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
What does this change
The blog posts have too much whitespace right now before H2 tags, which splits up the page oddly. This removes the extra space, just for blog posts.
What issue does it fix
NA
Notes for the reviewer
I could reduce the space even further because there is another padding statement that is adding padding to h2. That would impact ALL h2 tags on both blog posts and doc pages, not just the ones on the blog. What do you think?
Checklist
Reviewer Checklist