Improved permission system #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: basic permissions system
Feature: control the system name
Fix: create table only if it doesn't exists.
Logout button
…ve the same JSON result used in other query runners
… when length of series stays the same.
…plicitly add filters here too.
Feature: filters for all visualizations and not only tables
it wouldn't draw the chart with stacking other than none.
Feature: import query from json file
Fix ECMDERR
Added support for running scripts as queries
|
Thanks, @christophervalles-hailo. I've had a few busy days, but hopefully will merge it tomorrow. |
| migrator.add_column(models.User, models.User.groups, 'groups') | ||
|
|
||
| models.User.update(groups=['admin', 'default']).where(models.User.is_admin == True).execute() | ||
| models.User.update(groups=['default']).where(models.User.is_admin == False).execute() |
There was a problem hiding this comment.
Using only the is_admin flag is a problem, because since the introduction of the permission systems new users might have only the admin permission without this flag set. It's better to use either one of them and delete the permission column only after updating the group.
arikfr
added a commit
that referenced
this pull request
May 13, 2014
washort
pushed a commit
to washort/redash
that referenced
this pull request
Dec 13, 2017
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jan 8, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jan 9, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
Apr 30, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
May 31, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
Aug 11, 2018
alison985
pushed a commit
to StantonVentures/redash
that referenced
this pull request
Aug 19, 2018
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
This pull request is to improve the current role system. It adds the concept of groups, the permissions are per group instead of per user. A new feature has been added and it's the ability to filter what tables a group access, if you don't want to filter them you can just put an asterisk as wildcard.