Improve dashboard editing flow

[kocsmy]

• Hide Refresh, Share and Fullscreen while Unpublished
• Publish Dashboard should be visible and not hidden under …
• Stick dashboard header to the top
• Show Refresh button when Unpublished
• Hide Refresh, Share, Fullscreen and ... in Edit mode
• Stick Add New Widget to the bottom so it's always visible
• Hide empty parameter container (on query page) so it stops wasting space @kocsmy
• Finalise widget description: "Widgets are individual query visualisations you can place on your dashboard in various arrangements." @arikfr
• When creating a new dashboard, it should be in Edit Layout mode by default @arikfr
• Make Publish button consistent with Query Publish
• Enable filters checkbox should work properly (save its state) @arikfr

#2213

(until #2185 is merged this pull request contains commits from that branch too)

[kocsmy]

I merged from the query editor branch to make sure we won't have any big conflicts later on...

[kocsmy]

Ok, I merged the master here to ensure we won't have conflicts. I'm adding a couple of improvements and fixes.

[kocsmy]

We have 2 direction for the "Add widget" section: box and a wider line on the bottom. I think the wider option is better and it won't overlap on the widgets either.

[kocsmy]

This is the final version.

My only concern is the discoverability of the [Add Widget] button on a busy dashboard.

I'm not worried about new users, since they'll learn when create their first dashboard and see it in empty form. But users who already have dashboard, we totally moved the option from the usual ... menu—let's see how it'll go, maybe we need to fine-tune and add back the ... in Edit mode.

[kocsmy]

@arikfr is this a proper explanation for a widget: "Widgets are individual query visualisations you can place on your dashboard in various arrangements." how would you phrase it?

[arikfr]

is this a proper explanation for a widget: "Widgets are individual query visualisations you can place on your dashboard in various arrangements." how would you phrase it?

Just a small change: "Widgets are individual query visualizations or text boxes you can place...".

(visualizations btw, we use US spelling :-))

[arikfr]

I created the single dashboard edit mode + open new dashboard in edit mode. While doing this notice a few things:

• There is no discovery for being able to edit the title -> maybe there should be a pencil icon or something?
• "Publish Dashboard" button -> it's not consistent with the button on query page. Need to decide on a single format.

[kocsmy]

Thanks, Arik!

There is no discovery for being able to edit the title -> maybe there should be a pencil icon or something?

That's correct, I'll add an icon to open the modal (later we can implement the same click and edit on the title) -> no, actually let's keep it as it is for now so it's consistent across the app.

"Publish Dashboard" button -> it's not consistent with the button on query page. Need to decide on a single format.

I'll make this consistent, thanks for spotting it.

[arikfr]

That's correct, I'll add an icon to open the modal (later we can implement the same click and edit on the title)

There is already an edit in place.

[arikfr]

@kocsmy I'm not sure if this is really not needed, but after rebasing with latest master this part was making the background grey & transparent (you could see the footer behind the add-widget section). I merged the edit flow PR, but please review the CSS in the final state to make sure the rebase didn't mess up something...

[kocsmy]

Thanks for removing that part, it was indeed just a leftover from previous iterations. I'll review the CSS to make sure everything is in place.

[kocsmy]

Ok, I reviewed it and all seems good now. 👌