Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dashboard editing flow #2219

Merged
merged 17 commits into from
Jan 28, 2018
Merged

Improve dashboard editing flow #2219

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d9892f8
add new widget to the bottom of the dashboard
kocsmy Jan 9, 2018
84532f8
Improve dashboard widget creation and publish process with multiple d…
kocsmy Jan 14, 2018
d95c956
plenty of dashboard, filter and parameter fixes (still not the best, …
kocsmy Jan 14, 2018
043a1ee
Add missing class for consistency
kocsmy Jan 14, 2018
80e07c6
add ng-if to hide and show sections accordingly
kocsmy Jan 15, 2018
7b62ee8
Add extra header class and fixed styling
kocsmy Jan 15, 2018
9776081
position: sticke for dashboard-header
kocsmy Jan 16, 2018
4b74ab3
Styling improvements + show buttons in the right context
kocsmy Jan 18, 2018
cfb4a1c
Simplify markup and add more styling for add new widget box
kocsmy Jan 18, 2018
f7512f1
Fix schema hover on sub-items
kocsmy Jan 18, 2018
dd39166
Wider add widget section for dashboards
kocsmy Jan 18, 2018
b090b6b
Only render parameters div if we have parameters
kocsmy Jan 19, 2018
a98eff8
improve widget description
kocsmy Jan 19, 2018
c7dbe07
Single dashboard editing mode.
arikfr Jan 20, 2018
5a9b86f
make button texts consistent with queries
kocsmy Jan 22, 2018
4029821
Properly handle dashbaords filters toggle.
arikfr Jan 28, 2018
3aee4e9
remove second add-widget-container
arikfr Jan 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions client/app/assets/less/redash/redash-newstyle.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,6 @@ body {
}
}

.add-widget-container {
background: fade(@redash-gray, 10%);
border-radius: @redash-radius;
margin-top: 15px;
//box-shadow: fade(@redash-gray, 15%) 0px 4px 9px -3px;
border: 2px dashed fade(@redash-gray, 25%);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kocsmy I'm not sure if this is really not needed, but after rebasing with latest master this part was making the background grey & transparent (you could see the footer behind the add-widget section). I merged the edit flow PR, but please review the CSS in the final state to make sure the rebase didn't mess up something...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing that part, it was indeed just a leftover from previous iterations. I'll review the CSS to make sure everything is in place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I reviewed it and all seems good now. 👌


.database-source {
display: inline-flex;
flex-wrap: wrap;
Expand Down