Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query page long content unscrollable problem #2358

Closed

Conversation

tonyjiangh
Copy link
Contributor

Before

  • With long table, the query-metadata part and bottom-controller part disappeared(out of screen)
  • It's not scrollable
    image

After

  • I guess this is what we want?
    image

@kocsmy kocsmy requested a review from kravets-levko March 1, 2018 23:32
@kocsmy
Copy link
Collaborator

kocsmy commented Mar 1, 2018

Oh, thanks so much for spotting this @tonyjiangh and applying a fix 👍

@kravets-levko we might want to move the inline CSS code, please review and advise.

@kravets-levko
Copy link
Collaborator

@kocsmy We could keep it as inline CSS, it's fine in this case.

@tonyjiangh Thanks for this fix! Does it also work with smaller tables and other visualizations?

@kravets-levko
Copy link
Collaborator

kravets-levko commented Mar 2, 2018

@tonyjiangh I think you should create an issue for this because in Chrome everything looks fine even without this fix, but in Firefox this fix does not work properly:

Chrome:
image

Firefox without fix:
image

Firefox with fix (note that there is no scrollbar - it will appear at some point if I'll decrease window height. also scrollbar is cut):
image
image

I think we need another solution for this.

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment above

@tonyjiangh
Copy link
Contributor Author

@kravets-levko
Hmm, that's weird because I'm actually using Firefox for development, maybe this also depends on browser version or OS.

I'll create an issue for this and check for some other platform as well.

@kravets-levko
Copy link
Collaborator

@tonyjiangh It's my bad too - I mostly use Chrome and sometimes I forget to check markup in another browsers. And also it's strange that it does not work, because all visualizations have their own scrollbars on overflow. So, create an issue and will see what to do next. Anyway, thank you a lot that you noticed this!

@tonyjiangh
Copy link
Contributor Author

There's a more fundamental fix here, so this PR is closed.

@tonyjiangh tonyjiangh closed this Mar 2, 2018
@tonyjiangh tonyjiangh deleted the fix/query_content_overflow branch March 2, 2018 13:45
@arikfr
Copy link
Member

arikfr commented Mar 4, 2018

Thanks again, @tonyjiangh for raising the issue and taking a stab at a solution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants