-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query page long content unscrollable problem #2358
Conversation
Oh, thanks so much for spotting this @tonyjiangh and applying a fix 👍 @kravets-levko we might want to move the inline CSS code, please review and advise. |
@kocsmy We could keep it as inline CSS, it's fine in this case. @tonyjiangh Thanks for this fix! Does it also work with smaller tables and other visualizations? |
@tonyjiangh I think you should create an issue for this because in Chrome everything looks fine even without this fix, but in Firefox this fix does not work properly: Firefox with fix (note that there is no scrollbar - it will appear at some point if I'll decrease window height. also scrollbar is cut): I think we need another solution for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment above
@kravets-levko I'll create an issue for this and check for some other platform as well. |
@tonyjiangh It's my bad too - I mostly use Chrome and sometimes I forget to check markup in another browsers. And also it's strange that it does not work, because all visualizations have their own scrollbars on overflow. So, create an issue and will see what to do next. Anyway, thank you a lot that you noticed this! |
There's a more fundamental fix here, so this PR is closed. |
Thanks again, @tonyjiangh for raising the issue and taking a stab at a solution. 👍 |
Before
After