Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query page long visualization is unscrollable #2363

Merged
merged 1 commit into from
Mar 4, 2018
Merged

Query page long visualization is unscrollable #2363

merged 1 commit into from
Mar 4, 2018

Conversation

kravets-levko
Copy link
Collaborator

Issue #2361

Some browsers do not take in account that blocks with flex-grow: 1 may have overflow: auto blocks inside and always resize that blocks to fit their contents.

Fix: wrap content of blocks with flex-grow: 1 with absolutely positioned block. This allows browsers to stretch them to fit all free space (technically they do not have contents), and since wrapper has strict dimensions - scrollbars will appear as expected.

@kravets-levko
Copy link
Collaborator Author

@tonyjiangh I can't request your review, but please check this code too. Thanks!

@kravets-levko kravets-levko added this to the v4 milestone Mar 2, 2018
@tonyjiangh
Copy link
Contributor

@kravets-levko Thanks a lot for the fix. It works for me.
I'll close my PR.

@arikfr arikfr merged commit 6a072dd into getredash:master Mar 4, 2018
@kravets-levko kravets-levko deleted the bug/query-page-unscrollable branch February 11, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants