Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Github Oauth login support #3629

Closed
wants to merge 3 commits into from
Closed

Conversation

jupe
Copy link

@jupe jupe commented Mar 24, 2019

What type of PR is this?

  • Feature

Description

Github Oauth login support

Related Tickets & Documents

#2371

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Näyttökuva 2019-3-24 kello 9 13 05
image

@arikfr
Copy link
Member

arikfr commented Jan 21, 2020

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

@arikfr arikfr closed this Jan 21, 2020
@jupe jupe deleted the oauth_github branch February 29, 2020 09:12
@jupe jupe mentioned this pull request Feb 29, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants