Feature: GitHub OAuth support #4695
Conversation
user profile gives only primary email, but sometimes user might have another email address which domain is configured for redash. This change allows to login using secondary address also.
|
@rauchy thanks for review. I’ll update PR tomorrow. |
|
@rauchy is there still something you would like to change/add ? |
|
Hi, I plan to use Redash in our company and it'd be very nice if Redash has this feature. Is there any chance that this PR gets merged? Or may I re-work the PR based on current impl to fix those conflicts if you don't mind? |
|
Thanks @ocadaruma and @jupe for bumping this. It slipped off our radar. Will see about reviewing this again shortly. |
|
@jupe , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
What type of PR is this?
Description
Introduce Github OAuth authentication (again, #3629).
Related Tickets & Documents
Covers issue: #2371
Documentation PR: getredash/website#342
Mobile & Desktop Screenshots/Recordings (if there are UI changes)