Cypress: Force readonly inputs click #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
approved these changes
Jul 30, 2019
|
This error felt a bit weird to me, so I reached Cypress and it is actually supposed to only affect We can revert this once they solve it :) |
|
I knew it! |
gabrieldutra
added a commit
that referenced
this pull request
Nov 13, 2019
This reverts commit eae1fb7.
gabrieldutra
added a commit
that referenced
this pull request
Nov 13, 2019
This reverts commit eae1fb7.
1 task
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
After cypress update to v3.4.1 readonly inputs are not reachable by default, so I added
{ force: true }where needed to make existing CI tests pass again.Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--