-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Chrome Logger and update Cypress and Percy #4354
Conversation
@@ -12,7 +12,7 @@ function ParameterApplyButton({ paramCount, onClick }) { | |||
return ( | |||
<div className="parameter-apply-button" data-show={!!paramCount} data-test="ParameterApplyButton"> | |||
<Badge count={paramCount}> | |||
<Tooltip title={`${KeyboardShortcuts.modKey} + Enter`}> | |||
<Tooltip title={paramCount ? `${KeyboardShortcuts.modKey} + Enter` : null}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Tooltip was still up in front of some parameter inputs after clicking in "Apply All", blocking tests to continue
Percy highlighted that the Tooltip issue was not isolated to the Apply All button, now all clicked objects show their tooltips and since there's no unhover action on the tooltip or in the wrapped object, it stays open. |
@kravets-levko I wonder how this snapshot could change just by updating Cypress/Percy 🤔. You think it's a valid result too? (for me it's good, just need to be stable like that) |
@gabrieldutra I may be caused by different visualization container width (but not sure what may cause this, though). Both results look valid (there are no partially visible elements, font looks the same and so on), but the most reliable way to check which snapshot is correct is to run this test locally with the same browser window size we use for Percy. Also, I'm not sure if it will be stable result. |
Thanks @kravets-levko I actually just wanted to make sure it was still valid 😅, the rest I don't think it's worth it to be testing manually, we will see what happens over time :) |
What type of PR is this? (check all applicable)
Description
This removes the Chrome Logger (was causing issues with Cypress requests).
Also took the opportunity to:
Other than the chrome logger, solved some other issues that appeared in the specs.
Related Tickets & Documents
Closes #4286.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--