Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chrome Logger and update Cypress and Percy #4354

Merged
merged 13 commits into from
Nov 14, 2019

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Other

Description

This removes the Chrome Logger (was causing issues with Cypress requests).

Also took the opportunity to:

Other than the chrome logger, solved some other issues that appeared in the specs.

Related Tickets & Documents

Closes #4286.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

@@ -12,7 +12,7 @@ function ParameterApplyButton({ paramCount, onClick }) {
return (
<div className="parameter-apply-button" data-show={!!paramCount} data-test="ParameterApplyButton">
<Badge count={paramCount}>
<Tooltip title={`${KeyboardShortcuts.modKey} + Enter`}>
<Tooltip title={paramCount ? `${KeyboardShortcuts.modKey} + Enter` : null}>
Copy link
Member Author

@gabrieldutra gabrieldutra Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tooltip was still up in front of some parameter inputs after clicking in "Apply All", blocking tests to continue

@gabrieldutra
Copy link
Member Author

Percy highlighted that the Tooltip issue was not isolated to the Apply All button, now all clicked objects show their tooltips and since there's no unhover action on the tooltip or in the wrapped object, it stays open.

package.json Show resolved Hide resolved
client/cypress/plugins/index.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@gabrieldutra
Copy link
Member Author

@kravets-levko I wonder how this snapshot could change just by updating Cypress/Percy 🤔. You think it's a valid result too? (for me it's good, just need to be stable like that)

@kravets-levko
Copy link
Collaborator

@gabrieldutra I may be caused by different visualization container width (but not sure what may cause this, though). Both results look valid (there are no partially visible elements, font looks the same and so on), but the most reliable way to check which snapshot is correct is to run this test locally with the same browser window size we use for Percy. Also, I'm not sure if it will be stable result.

@gabrieldutra
Copy link
Member Author

Thanks @kravets-levko I actually just wanted to make sure it was still valid 😅, the rest I don't think it's worth it to be testing manually, we will see what happens over time :)

@gabrieldutra gabrieldutra merged commit 0aebb37 into master Nov 14, 2019
@gabrieldutra gabrieldutra deleted the cypress-percy-update branch November 14, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Cypress tests work with Cypress@3.6.0
3 participants