Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter feedback - #3 Added in Widgets #4320

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 30, 2019

  • Feature

Description

Extended the new feature to dashboard and embedded widgets.

Screen Shot 2019-10-30 at 20 02 45

  • Basic Cypress tests

@ranbena ranbena self-assigned this Oct 30, 2019
@ranbena ranbena marked this pull request as ready for review October 31, 2019 07:59
* Parameter feedback - #4 Added in Dashboard params

* Added cypress test

* Moved to service

* Parameter feedback - #5 Unsaved indication (#4322)

* Parameter feedback - #5 Unsaved indication

* Added ANGULAR_REMOVE_ME

* Added cypress test

* Fixed percy screenshot

* Some code improvements

* Parameter input feedback - #6 Better value normalization (#4327)
@guidopetri guidopetri merged commit 839d80d into param-feedback-2 Jul 21, 2023
@guidopetri guidopetri deleted the param-feedback-3 branch July 21, 2023 19:36
guidopetri pushed a commit that referenced this pull request Jul 21, 2023
* Parameter feedback - #2 Client errors in query page

* Added cypress test

* Fixed percy screenshot

* Safer touched change

* Parameter feedback - #3 Added in Widgets (#4320)

* Parameter feedback - #3 Added in Widgets

* Added cypress tests

* Making sure widget-level param is selected

* Parameter feedback - #4 Added in Dashboard params (#4321)

* Parameter feedback - #4 Added in Dashboard params

* Added cypress test

* Moved to service

* Parameter feedback - #5 Unsaved indication (#4322)

* Parameter feedback - #5 Unsaved indication

* Added ANGULAR_REMOVE_ME

* Added cypress test

* Fixed percy screenshot

* Some code improvements

* Parameter input feedback - #6 Better value normalization (#4327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants