Parameter feedback - #4 Added in Dashboard params #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
commented
Oct 30, 2019
ranbena
force-pushed
the
param-feedback-4
branch
from
cd69ffc to
fbfa980
Compare
ranbena
force-pushed
the
param-feedback-3
branch
from
fd5ffb2 to
6467ad4
Compare
ranbena
force-pushed
the
param-feedback-4
branch
from
fbfa980 to
dd588f4
Compare
ranbena
force-pushed
the
param-feedback-3
branch
from
6467ad4 to
ad619b8
Compare
ranbena
force-pushed
the
param-feedback-4
branch
from
dd588f4 to
557c9ba
Compare
ranbena
force-pushed
the
param-feedback-3
branch
from
6a11a87 to
db729a9
Compare
ranbena
force-pushed
the
param-feedback-4
branch
from
557c9ba to
7e3a02a
Compare
kravets-levko
approved these changes
Nov 4, 2019
This was referenced Nov 4, 2019
guidopetri
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Parameter feedback - #3 Added in Widgets * Added cypress tests * Making sure widget-level param is selected * Parameter feedback - #4 Added in Dashboard params (#4321) * Parameter feedback - #4 Added in Dashboard params * Added cypress test * Moved to service * Parameter feedback - #5 Unsaved indication (#4322) * Parameter feedback - #5 Unsaved indication * Added ANGULAR_REMOVE_ME * Added cypress test * Fixed percy screenshot * Some code improvements * Parameter input feedback - #6 Better value normalization (#4327)
guidopetri
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Parameter feedback - #2 Client errors in query page * Added cypress test * Fixed percy screenshot * Safer touched change * Parameter feedback - #3 Added in Widgets (#4320) * Parameter feedback - #3 Added in Widgets * Added cypress tests * Making sure widget-level param is selected * Parameter feedback - #4 Added in Dashboard params (#4321) * Parameter feedback - #4 Added in Dashboard params * Added cypress test * Moved to service * Parameter feedback - #5 Unsaved indication (#4322) * Parameter feedback - #5 Unsaved indication * Added ANGULAR_REMOVE_ME * Added cypress test * Fixed percy screenshot * Some code improvements * Parameter input feedback - #6 Better value normalization (#4327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended feature to Dashboard parameters.
This was a tricky one - needs aggregating all query results from widgets and filtering out the dashboard ones. But it works!