Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource Exasol: support encryption setting #4712

Merged
merged 5 commits into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion redash/query_runner/exasol.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,10 @@ def configuration_schema(cls):
"password": {"type": "string"},
"host": {"type": "string"},
"port": {"type": "number", "default": 8563},
"encrypted": {"type": "boolean", "title": "Enable SSL Encryption"},
},
"required": ["host", "port", "user", "password"],
"order": ["host", "port", "user", "password"],
"order": ["host", "port", "user", "password", "encrypted"],
"secret": ["password"],
}

Expand All @@ -81,6 +82,7 @@ def _get_connection(self):
dsn=exahost,
user=self.configuration.get("user", None),
password=self.configuration.get("password", None),
encryption=self.configuration.get("encrypted", True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While having SSL enabled is a good default, but this will change it for existing deployments as well. How common would it be for an Exasol deployment not to have SSL support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSL support is build in into the Exasol Engine, so all deployments which support WebSockets also have SSL capabilities

compression=True,
json_lib="rapidjson",
fetch_mapper=_exasol_type_mapper,
Expand Down
2 changes: 1 addition & 1 deletion requirements_all_ds.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ phoenixdb==0.7
certifi>=2019.9.11
pydgraph==2.0.2
azure-kusto-data==0.0.35
pyexasol==0.9.1
pyexasol==0.12.0
python-rapidjson==0.8.0
pyodbc==4.0.28