Datasource Exasol: support encryption setting #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pyexasol datasource, ensure that integer dont overflow in javascript
arikfr
reviewed
Mar 8, 2020
| @@ -81,6 +82,7 @@ def _get_connection(self): | |||
| dsn=exahost, | |||
| user=self.configuration.get("user", None), | |||
| password=self.configuration.get("password", None), | |||
| encryption=self.configuration.get("encrypted", True), | |||
There was a problem hiding this comment.
While having SSL enabled is a good default, but this will change it for existing deployments as well. How common would it be for an Exasol deployment not to have SSL support?
There was a problem hiding this comment.
SSL support is build in into the Exasol Engine, so all deployments which support WebSockets also have SSL capabilities
|
👍 thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This adds support to toggle SSL Encryption for connections to Exasol
See also https://github.com/badoo/pyexasol/blob/master/docs/ENCRYPTION.md