forked from getredash/redash
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pyexasol datasource, ensure that integer dont overflow in javascript #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S credentials. (getredash#4344) Without this upgrades from at least v5 (and earlier) won't work.
inytar
reviewed
Nov 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small comment, but looks good to me!
inytar
approved these changes
Nov 12, 2019
* Migrate Cohort to React: Editor * Extract prepareData and getOptions to own files * Refine CohortRenderer Angular component (js, less, prepareData) for easier migration * Migrate Cohort to React: Renderer * Migrate Cornelius to React: styles * Migrate Cohort to React: Cornelius library * Cornelius: add licence info; remove unused style * Cornelius: use numeral to format numbers; revisit styles * Cornelius: use moment to format date labels * Cornelius: use chroma for cell backgrounds; update options; update proptypes; minor fixes * Tidy up * Tests
* Fix: correctly evaluate numeric thresholds * Missing import * More missing imports * Alert evaluation: support for booleans
* Script to reencrypt data source options. * Implement reencrypt sub command under database command.
* use to set the hash instead of directly manipulating it * Update Jobs.jsx
* Migrate Choropleth to React: skeleton * Migrate Choropleth to React: Editor - skeleton * Choropleth Editor: Bounds tab * Choropleth Editor: Colors tab * Choropleth Editor: Format tab * Choropleth Editor: General tab * Some refinements * Migrate Choropleth to React: Renderer * Refine code * CR1
* Migrate Funnel visualization to React: Editor * Migrate Funnel visualization to React: Renderer * Replace Auto sort options with Sort Column + Reverse Order * Add option for items limit (instead of hard-coded value) * Add number formatting options * Replace d3.max with lodash.maxBy; fix bug in prepareData * Add options for min/max percent values * Debounce inputs * Tests * Refine Renderer: split components, use Ant Table for rendering, fix data handling * Extract utility function to own file * Fix tests * Fix: sometimes after updating options, funnel shows "ghost" rows from previous dataset * Sort by value column by default
26dc27f
to
25798fc
Compare
25798fc
to
1673093
Compare
* Remove ui-ace. * Remove ui-sortable. * Remove angular-base64-upload. * Remove angular-messages. * Remove jquery-ui. * Update package-lock.json.
* Hide deprecated visualizations from query editor * Fix Map tests
These few builtins were available in Python 2.7 but not anymore in Python 3, making the runner fail to start.
* CloudWatch Metrics query runner * Add: query runner for CloudWatch Logs Insights * Add logos * Update Insights type * Basic test connection * Format files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is adding pyexasol as datasource to redash, to do so we need to use master cause the python 3.x changes have not been released yet. It also fixes the issue with overflowing numbers in Javascript. We could consider opening a pull against redash so we dont need to maintain our own fork in the future