Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Percy snapshot for Choropleth test #4799

Merged
merged 6 commits into from
Apr 14, 2020

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Apr 14, 2020

What type of PR is this? (check all applicable)

  • Other

Description

The snapshot test fails almost on every PR and has no value. Disabled until a better solution is found.

Related Tickets & Documents

redashlabs/product#53

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kravets-levko
Copy link
Collaborator

@arikfr Since you're already on this - can you try in increase delay in cy.wait() few lines above? I guess it fails all the time because it does not respond to options changes fast enough.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kravets-levko
Copy link
Collaborator

I didn't work (the map should be red&yellow) 🤔 Okay, let's just disable it for now, I'll check it later

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
arikfr and others added 3 commits April 14, 2020 12:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Restyled.io <commits@restyled.io>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@arikfr arikfr merged commit 2c1eb5c into master Apr 14, 2020
@arikfr arikfr deleted the disable-choropleth-percy-test branch April 14, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants