Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Percy snapshot for Choropleth test #4799

Merged
merged 6 commits into from
Apr 14, 2020
Merged

Disable Percy snapshot for Choropleth test #4799

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41f64c1
Disable Percy snapshot for Choropleth test
arikfr Apr 14, 2020
46255a0
Increase wait.
arikfr Apr 14, 2020
5e978eb
Diasble Percy snapshot.
arikfr Apr 14, 2020
1e5bfcb
Reduce wait time to original value.
arikfr Apr 14, 2020
8eb750b
Restyled by prettier (#4800)
restyled-io[bot] Apr 14, 2020
9d19c8c
Update choropleth_spec.js
arikfr Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions client/cypress/integration/visualizations/choropleth_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global cy, Cypress */
/* global cy */

import { createQuery } from "../../support/redash-api";

Expand Down Expand Up @@ -30,8 +30,6 @@ const SQL = `
`;

describe("Choropleth", () => {
const viewportWidth = Cypress.config("viewportWidth");

beforeEach(() => {
cy.login();
createQuery({ query: SQL }).then(({ id }) => {
Expand Down Expand Up @@ -85,6 +83,9 @@ describe("Choropleth", () => {
cy.getByTestId("VisualizationPreview")
.find(".map-visualization-container.leaflet-container")
.should("exist");
cy.percySnapshot("Visualizations - Choropleth", { widths: [viewportWidth] });

// This is unstable and therefore disabled until a better solution is available.
// const viewportWidth = Cypress.config("viewportWidth");
// cy.percySnapshot("Visualizations - Choropleth", { widths: [viewportWidth] });
});
});