Show explicit user name instead of avatar in lists. #4828
Conversation
|
Hey there- I'm a bot, here to let you know that some code in this PR might not Please see that Pull Request's description for more details. |
| Columns.dateTime.sortable({ title: "Last Executed At", field: "retrieved_at", orderByField: "executed_at" }), | ||
| Columns.custom.sortable((text, item) => <SchedulePhrase schedule={item.schedule} isNew={item.isNew()} />, { | ||
| title: "Update Schedule", | ||
| title: "Refresh Schedule", |
There was a problem hiding this comment.
Fixed for consistency with the page.
| Columns.dateTime.sortable({ title: "Created At", field: "created_at" }), | ||
| Columns.duration.sortable({ title: "Runtime", field: "runtime" }), |
There was a problem hiding this comment.
It doesn't feel very useful so removed it to have more space for names.
| @@ -41,7 +41,9 @@ function DashboardPageTitle({ dashboardOptions }) { | |||
| ignoreBlanks | |||
| /> | |||
| </h3> | |||
| <img src={dashboard.user.profile_image_url} className="profile-image" alt={dashboard.user.name} /> | |||
| <Tooltip title={dashboard.user.name} placement="bottom"> | |||
There was a problem hiding this comment.
FWIW: This event doesn't work on mobile since there's no "hover" event. Not a big deal but maybe something to address down the road.
There was a problem hiding this comment.
On mobile you can click on it to see the tooltip.
There was a problem hiding this comment.
This doesn't work on the latest iOS via iPhone XS. Does work on iPad.
There was a problem hiding this comment.
It worked for me on iPhone X. 😮
There was a problem hiding this comment.
I bet that even if this didn't work it wouldn't impact many users 🤷♂️
|
How to add sortable to 'Created By'? I add orderByfield 'created_by', it worded for query list but not for dabhoard list page. |
What type of PR is this? (check all applicable)
Description
In several places in the application we show only the user avatar instead of their name. In large organizations that don't use avatars this leads to long lists with random icons instead of names.
There is probably a better UX to be achieved by moving the user name to a second line below the object name, but compared to the effort this seemed like a quick win.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)