Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show explicit user name instead of avatar in lists. #4828

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Show explicit user name instead of avatar in lists. #4828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/app/pages/alerts/AlertsList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class AlertsList extends React.Component {
field: "name",
}
),
Columns.custom((text, item) => item.user.name, { title: "Created By" }),
Columns.custom.sortable(
(text, alert) => (
<div>
Expand All @@ -59,7 +60,6 @@ class AlertsList extends React.Component {
}
),
Columns.timeAgo.sortable({ title: "Last Updated At", field: "updated_at", className: "text-nowrap", width: "1%" }),
Columns.avatar({ field: "user", className: "p-l-0 p-r-0" }, name => `Created by ${name}`),
Columns.dateTime.sortable({ title: "Created At", field: "created_at", className: "text-nowrap", width: "1%" }),
];

Expand Down
2 changes: 1 addition & 1 deletion client/app/pages/dashboards/DashboardList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class DashboardList extends React.Component {
width: null,
}
),
Columns.avatar({ field: "user", className: "p-l-0 p-r-0" }, name => `Created by ${name}`),
Columns.custom((text, item) => item.user.name, { title: "Created By" }),
Columns.dateTime.sortable({
title: "Created At",
field: "created_at",
Expand Down
4 changes: 3 additions & 1 deletion client/app/pages/dashboards/components/DashboardHeader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ function DashboardPageTitle({ dashboardOptions }) {
ignoreBlanks
/>
</h3>
<img src={dashboard.user.profile_image_url} className="profile-image" alt={dashboard.user.name} />
<Tooltip title={dashboard.user.name} placement="bottom">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: This event doesn't work on mobile since there's no "hover" event. Not a big deal but maybe something to address down the road.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile you can click on it to see the tooltip.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on the latest iOS via iPhone XS. Does work on iPad.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me on iPhone X. 😮

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet that even if this didn't work it wouldn't impact many users 🤷‍♂️

<img src={dashboard.user.profile_image_url} className="profile-image" alt={dashboard.user.name} />
</Tooltip>
</div>
<DashboardTagsControl
tags={dashboard.tags}
Expand Down
5 changes: 2 additions & 3 deletions client/app/pages/queries-list/QueriesList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,11 @@ class QueriesList extends React.Component {
width: null,
}
),
Columns.avatar({ field: "user", className: "p-l-0 p-r-0" }, name => `Created by ${name}`),
Columns.custom((text, item) => item.user.name, { title: "Created By" }),
Columns.dateTime.sortable({ title: "Created At", field: "created_at" }),
Columns.duration.sortable({ title: "Runtime", field: "runtime" }),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't feel very useful so removed it to have more space for names.

Columns.dateTime.sortable({ title: "Last Executed At", field: "retrieved_at", orderByField: "executed_at" }),
Columns.custom.sortable((text, item) => <SchedulePhrase schedule={item.schedule} isNew={item.isNew()} />, {
title: "Update Schedule",
title: "Refresh Schedule",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for consistency with the page.

field: "schedule",
}),
];
Expand Down