Pymongo version upgrade changes #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arikfr can this get some love please. The build is breaking in Athena test cases that has no connection to the files that have been changed. |
arikfr
reviewed
Apr 15, 2023
arikfr
reviewed
Apr 16, 2023
2 tasks
justinclift
force-pushed
the
pymongo-version-upgrade
branch
from
56d9a8c to
12c75e5
Compare
|
In theory, this PR looks like a better MongoDB update than PR #6114. So, I just rebased this onto our master branch so the CI tests will run. If the CI tests fully pass, this is the better one to merge. 😄 |
myonlylonely
added a commit
to myonlylonely/redash-custom
that referenced
this pull request
Jul 2, 2023
* commit 'ee601ec20676b0705e352bfb9b6726a0e53e3b12': Fix `FEATURE_POLICY` to initialize from `REDASH_FEATURE_POLICY` envvar, not `REDASH_REFERRER_POLICY` (getredash#5822) Update to latest in yarn 1.22.x series (getredash#6140) Use precompiled psycopg2-binary package instead of psycopg2 (getredash#6137) Pymongo version upgrade changes (getredash#5970) Bump jinja2 from 2.10.3 to 2.11.3 (getredash#5431) Update Python dependencies to eliminate version conflicts (getredash#6122) Upgrade Python version to 3.8 (getredash#6130) Try fixing cypress in a more correct way (getredash#6117) ci: Attempt to fix restyled.io test (getredash#6116) fix pivot table style error (getredash#6112) dependencies: pystache==0.6.0 (getredash#6091) ci: migrate to github workflow ci (getredash#6008) Update Simba ODBC driver (getredash#6110)
6 tasks
10 tasks
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* Pymongo version upgrade changes * Get count logic has been changed to get using count_documents method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
JSONOptionfrombson.json_utilssetstz_awaretoFalsefrom 4.0 (https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html#tz-aware-defaults-to-false), so setting value toTrueexplicitly indatetime_parsercollection_namesmethod has been changed tolist_collection_names(https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html#database-collection-names-is-removed)countmethod has been changed and usinglento get the length fromcursorsincecountmethod has been removed from 4.0 (https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html#collection-count-and-cursor-count-is-removed)How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)