Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate to github workflow ci #6008

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Conversation

junnplus
Copy link
Member

@junnplus junnplus commented Apr 26, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@junnplus junnplus marked this pull request as draft April 26, 2023 07:35
@junnplus junnplus changed the title ci: add github workflow ci ci: migrate to github workflow ci Apr 27, 2023
@junnplus junnplus marked this pull request as ready for review April 27, 2023 12:17
@Avey777
Copy link
Collaborator

Avey777 commented May 5, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

I'm looking forward to you merging the code into the main branch, everyone is waiting here

@justinclift
Copy link
Member

justinclift commented May 11, 2023

As a data point, this PR worked fine in the new RedashCommunity fork once we removed --record from the Cypress line, as we're not setup to record: RedashCommunity@a5d12b1

That's unlikely to be a problem here though, so it should be fine as-is. In theory. 😉

@gabrieldutra
Copy link
Member

I did not have time to fully test it (i.e.: artifacts, BE jobs, any automated master script), but when I checked the only thing I could notice was related to the Cypress Cloud itself, as the Git context was lost from it:

Screenshot 2023-05-11 at 13 44 12

@justinclift
Copy link
Member

justinclift commented May 11, 2023

Ahhh. Yeah, that might indicate something that needs looking into for this repo.

For the RedashCommunity repo, we're still figuring out how all the pieces fit together. eg there are hard coded keys in parts of the CI, so we're avoiding uploading to Cypress Cloud, Percy (etc) until we have a better handle on stuff. 😄

@justinclift
Copy link
Member

Ugh. I rebased it onto the wrong repo master. 🤦

Fixing...

Signed-off-by: Ye Sijun <junnplus@gmail.com>
@justinclift justinclift merged commit f3892e0 into getredash:master Jun 24, 2023
@justinclift
Copy link
Member

@junnplus This is finally merged here! 😄

myonlylonely added a commit to myonlylonely/redash-custom that referenced this pull request Jul 2, 2023
* commit 'ee601ec20676b0705e352bfb9b6726a0e53e3b12':
  Fix `FEATURE_POLICY` to initialize from `REDASH_FEATURE_POLICY` envvar, not `REDASH_REFERRER_POLICY` (getredash#5822)
  Update to latest in yarn 1.22.x series (getredash#6140)
  Use precompiled psycopg2-binary package instead of psycopg2 (getredash#6137)
  Pymongo version upgrade changes (getredash#5970)
  Bump jinja2 from 2.10.3 to 2.11.3 (getredash#5431)
  Update Python dependencies to eliminate version conflicts (getredash#6122)
  Upgrade Python version to 3.8 (getredash#6130)
  Try fixing cypress in a more correct way (getredash#6117)
  ci: Attempt to fix restyled.io test (getredash#6116)
  fix pivot table style error (getredash#6112)
  dependencies: pystache==0.6.0 (getredash#6091)
  ci: migrate to github workflow ci (getredash#6008)
  Update Simba ODBC driver (getredash#6110)
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Signed-off-by: Ye Sijun <junnplus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants