This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
ref: Delete empty properties before sending event to the server #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Dec 8, 2017
SimonSchick
reviewed
Dec 9, 2017
lib/client.js
Outdated
| } | ||
| // Cleanup empty properties before sending them to the server | ||
| Object.keys(kwargs).forEach(function(key) { | ||
| if (typeof kwargs[key] === 'undefined' || kwargs[key] === '') { |
There was a problem hiding this comment.
Why not just use kwargs[key] === undefined, the typeof check is only really needed for globals.
There was a problem hiding this comment.
I'm just used to use this check instead. It doesn't change any performance characteristics, as it's just one lookup. Although I think we should include null here as well, so we should end up with kwargs[key] == null || kwargs[key] === '' instead (allowing for 0 to be passed).
kamilogorek
force-pushed
the
remove-default-logger
branch
from
13f5038 to
2590a1f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406