Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Delete empty properties before sending event to the server #1179

Merged
merged 2 commits into from
Dec 20, 2017
Merged

ref: Delete empty properties before sending event to the server #1179

merged 2 commits into from
Dec 20, 2017

Conversation

kamilogorek
Copy link
Contributor

Fixes: #1164
Raven-node ref: getsentry/raven-node#407

@kamilogorek kamilogorek requested a review from a team December 20, 2017 11:31
HazAT
HazAT approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this fixes #1164
But LGTM 👍

@kamilogorek
Copy link
Contributor Author

@HazAT right, it was getsentry/raven-node#406 :P I just wanted to unify it with Raven.js

@kamilogorek kamilogorek merged commit bd3bd9d into master Dec 20, 2017
@kamilogorek kamilogorek deleted the strip-empty-attributes branch December 20, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilogorek @HazAT