Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerations in public interfaces need a catch-all type #1639

Closed
9 tasks done
jan-auer opened this issue Nov 25, 2022 · 1 comment
Closed
9 tasks done

Enumerations in public interfaces need a catch-all type #1639

jan-auer opened this issue Nov 25, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jan-auer
Copy link
Member

jan-auer commented Nov 25, 2022

@jan-auer jan-auer added the bug Something isn't working label Nov 25, 2022
@jan-auer jan-auer added this to the Maintenance milestone Nov 25, 2022
@jjbayer
Copy link
Member

jjbayer commented Nov 30, 2022

Found the following problematic enums (internal doc): https://www.notion.so/sentry/Forward-compatibility-of-enums-5eafecc16a014cbab13dbab3791ccef3

@jjbayer jjbayer removed their assignment Jan 10, 2023
TBS1996 added a commit that referenced this issue Jan 18, 2023
adds an unknown field to SessionStatus enum. This is for cases where a
user has an outdated relay and receives an enum variant not in his
version of relay. In those cases the name of the enum will be stored in
a string and be passed on.

#1639
TBS1996 added a commit that referenced this issue Feb 1, 2023
Adds a new enum variant to ruletype for forward-compatibility

#1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants