fix(server): Forward-compatible AttachmentType #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
reviewed
Nov 25, 2022
jjbayer
commented
Nov 25, 2022
| let breadcrumbs2 = envelope | ||
| .take_item_by(|item| item.attachment_type() == Some(AttachmentType::Breadcrumbs)); | ||
| .take_item_by(|item| item.attachment_type() == Some(&AttachmentType::Breadcrumbs)); |
There was a problem hiding this comment.
AttachmentType is not Copy anymore, because one of its variants now contains a String.
olksdr
approved these changes
Nov 25, 2022
9 tasks
jan-auer
requested changes
Nov 25, 2022
@iker-barriocanal we will add a specific variant for the view hierarchy in a different PR, so this PR actually won't help with the rollout of that new type. It only ensures that when we add attachment types in the future, envelopes will not be dropped by external Relays. |
jan-auer
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did in #1246 for
ItemType, add anUnknown(String)variant toAttachmentType. Whenaccept_unknown_itemsis set to false, items with this attachment type will be dropped.This will allow outdated external Relays to forward new attachment types instead of dropping the entire envelope.
This defect was discovered in getsentry/rfcs#33, which introduces a new attachment type.