Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP scrubbing removes chrome version #1826

Closed
TBS1996 opened this issue Feb 8, 2023 · 2 comments · Fixed by #2641
Closed

IP scrubbing removes chrome version #1826

TBS1996 opened this issue Feb 8, 2023 · 2 comments · Fixed by #2641
Assignees
@Dav1dde @smeubank
Labels
bug Something isn't working maintenance Tasks with this label generally have a lower priority and due date onboarding

Comments

@TBS1996
Copy link
Contributor

TBS1996 commented Feb 8, 2023 •
edited by iker-barriocanal
Loading

Michael Chai reported that a customer got a false positive where ip scrubbing removed the browser version. Customer issue here.

https://files.slack.com/files-pri/T024ZCV9U-F04NU8URXGR/image.png

Perhaps we should add user agent to the default safe fields?
@TBS1996 TBS1996 added the bug Something isn't working label Feb 8, 2023
@olksdr
Copy link
Contributor

olksdr commented Feb 13, 2023 •
edited
Loading

Ideas:

  • disable IP scrubbing for user_agent header or/and client hints

@olksdr olksdr added this to the Maintenance milestone Feb 13, 2023
@ndmanvar ndmanvar assigned ndmanvar and smeubank and unassigned ndmanvar Mar 13, 2023
@smeubank
Copy link
Member

I think it's best to loop in @jan-auer here i see someone from ingest already create tge issue

@TBS1996 the default safe fields: would you need any changes in thr JS SDK for this?

@jernejstrasner jernejstrasner added the maintenance Tasks with this label generally have a lower priority and due date label Mar 23, 2023
@jernejstrasner jernejstrasner removed this from the Maintenance milestone Mar 23, 2023
@TBS1996 TBS1996 self-assigned this Jun 26, 2023
@roggenkemper roggenkemper mentioned this issue Jun 26, 2023
Closed
@Dav1dde Dav1dde mentioned this issue Oct 20, 2023
Merged
@olksdr olksdr assigned Dav1dde and unassigned TBS1996 Oct 21, 2023
Dav1dde added a commit that referenced this issue Oct 30, 2023
@Dav1dde
fix(pii): Disable scrubbing for the User-Agent header (#2641)
a705740 
Some User-Agents are being scrubbed by the IP rule, this disables
scrubbing for the entire Header

Fixes: #1826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dav1dde Dav1dde

@smeubank smeubank

Labels
bug Something isn't working maintenance Tasks with this label generally have a lower priority and due date onboarding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pii): Disable scrubbing for the User-Agent header
6 participants
@Dav1dde @ndmanvar @jernejstrasner @olksdr @smeubank @TBS1996