Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pii): Disable scrubbing for the User-Agent header #2641

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(pii): Disable scrubbing for the User-Agent header #2641

merged 2 commits into from
Oct 30, 2023

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Oct 20, 2023

Some User-Agents are being scrubbed by the IP rule, this disables scrubbing for the entire Header as suggested here #1826 (comment)

Fixes: #1826

Some User-Agents are being scrubbed by the IP rule.

Fixes: #1826
@Dav1dde Dav1dde requested a review from a team October 20, 2023 09:47
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as Olek, other than that LGTM!

relay-pii/src/processor.rs Outdated Show resolved Hide resolved
@Dav1dde Dav1dde changed the title fix(pii): Disable scrubbing for the User-Agent header (#1826) fix(pii): Disable scrubbing for the User-Agent header Oct 30, 2023
@Dav1dde Dav1dde merged commit a705740 into getsentry:master Oct 30, 2023
20 checks passed
@Dav1dde Dav1dde deleted the dav/fix/pii-user-agent branch October 30, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP scrubbing removes chrome version
3 participants