Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply inbound filters to spans (using abstraction layer) #3317

Closed
2 of 3 tasks
jjbayer opened this issue Mar 25, 2024 · 2 comments
Closed
2 of 3 tasks

Apply inbound filters to spans (using abstraction layer) #3317

jjbayer opened this issue Mar 25, 2024 · 2 comments
Assignees
@iambriccardo

Comments

@jjbayer
Copy link
Member

jjbayer commented Mar 25, 2024 •
edited by iambriccardo
Loading

Tasks
Preview Give feedback
  2. Call inbound filter logic in in span::process. #3550
    iambriccardo
  3. Implement event. getters for spans to have a compatibility mode for generic inbound filters. This is a best-effort task, probably only a handful of fields make sense (e.g. release, environment, ...). #3551
    iambriccardo
@jjbayer jjbayer mentioned this issue Mar 25, 2024
Closed
@jjbayer
Copy link
Member Author

jjbayer commented Mar 25, 2024

Set Apr 9 as due date, because Replays depend on the abstraction layer as well.

@jjbayer jjbayer self-assigned this Apr 9, 2024
@jjbayer jjbayer mentioned this issue Apr 9, 2024
Merged
jjbayer added a commit that referenced this issue Apr 9, 2024
@jjbayer @iker-barriocanal
ref(filters): Access fields through trait (#3397)
c7bc957 
Currently, inbound filters only work for event types, that is error
events and transactions. In the near future we will want inbound filters
to apply to other data types as well, such as standalone spans and
session replays. To prepare for this generalization, make filters act on
a trait that supplies the necessary field instead of the `Event` itself:

```rust
// `Filterable` for legacy inbound filters,
// `Getter` for generic inbound filters.
pub fn should_filter<F: Filterable + Getter>(item: &F, ...); 
```

ref: #3317

---------

Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
@jjbayer
Copy link
Member Author

jjbayer commented Apr 16, 2024

New due date is Apr 30, because Replays are already unbocked by #3397.

@jjbayer jjbayer assigned iker-barriocanal and unassigned jjbayer Apr 16, 2024
@iker-barriocanal iker-barriocanal removed their assignment Apr 24, 2024
@jjbayer jjbayer mentioned this issue May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iambriccardo iambriccardo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jjbayer @iambriccardo @iker-barriocanal