ref(filters): Access fields through trait #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
commented
Apr 9, 2024
Comment on lines
-11
to
-13
| if event.ty.value() != Some(&EventType::Transaction) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This check moved to the trait implementation.
jjbayer
commented
Apr 9, 2024
| use relay_event_schema::protocol::{Csp, Event, EventType, Exception, LogEntry, Values}; | ||
|
|
||
| /// A data item to which filters can be applied. | ||
| pub trait Filterable { |
There was a problem hiding this comment.
I'm open for ideas on how to name this trait.
jjbayer
commented
Apr 9, 2024
| pub fn matches(event: &Event, browsers: &BTreeSet<LegacyBrowser>) -> bool { | ||
| if let Some(user_agent_string) = event.user_agent() { | ||
| let user_agent = relay_ua::parse_user_agent(user_agent_string); | ||
| fn matches(user_agent: &str, browsers: &BTreeSet<LegacyBrowser>) -> bool { |
There was a problem hiding this comment.
I made the matches functions private everywhere, they do not need to be public.
iker-barriocanal
approved these changes
Apr 9, 2024
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
cmanallen
approved these changes
Apr 9, 2024
jjbayer
commented
Apr 9, 2024
There was a problem hiding this comment.
nit: we should align all matches implementations for consistency
@iker-barriocanal They are all private functions, so IMO they should do what makes the most sense in local context. I pass the value directly where the function needs only that value, and the full item in cases where the function needs more than one value. Let me know if that makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, inbound filters only work for event types, that is error events and transactions. In the near future we will want inbound filters to apply to other data types as well, such as standalone spans and session replays. To prepare for this generalization, make filters act on a trait that supplies the necessary field instead of the
Eventitself:ref: #3317
#skip-changelog