Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): Do not create aggregators without metrics #1003

Merged
merged 3 commits into from
May 18, 2021
Merged

fix(metrics): Do not create aggregators without metrics #1003

merged 3 commits into from
May 18, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 18, 2021 •
edited
Loading

This is a first workaround to avoid overloading the project arbiter with too many aggregators. This only avoids creating aggregators. The leak itself still exists.

Follow-ups:

  • Move metrics aggregation to its own arbiter
  • Use a better approach than busy polling for metrics

Fixes a regression in #986

@jan-auer jan-auer self-assigned this May 18, 2021
@jan-auer jan-auer requested a review from a team May 18, 2021 08:55
@jan-auer jan-auer merged commit 842236e into master May 18, 2021
@jan-auer jan-auer deleted the fix/no-idle-aggregators branch May 18, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @jjbayer